Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all of the trimmer aware of recursive interfaces #103317

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
+2,038 −288

Merge branch 'main' into RecursiveGenericInterfaces

f285f9a
Select commit
Loading
Failed to load commit list.
Open

Make all of the trimmer aware of recursive interfaces #103317

Merge branch 'main' into RecursiveGenericInterfaces
f285f9a
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Aug 29, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

⚠️ The following pipeline(s) will not be analyzed as has been explicited excluded from analysis

Known Infrastructure Errors

Build Failures

runtime / Build / wasi-wasm linux Release LibraryTests_Smoke_AOT

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌The job running on agent NetCore-Public 494 ran longer than the maximum time of 240 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

Test Failures (1 tests failed)

🔹 [All failing tests from runtime]

    ❌ Mono.Linker.Tests.TestCases.All.RequiresCapability [Details] [0.48% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration
    Data Driven SubResults
      ❌ Mono.Linker.Tests.TestCases.All.RequiresCapability(t: \"BaseProvidesInterfaceMethodRequiresMismatch\")
      Exception Message
      Expected to find warning: warning IL2046: Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.BaseImplementsINoRuc.D: and message containing 'C.M()' 'INoRuc.M()', but no such message was found.\nLogged messages:\nILC: Trim analysis warning IL2026: <Module>.MainMethodWrapper(): Using member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.Main()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Message.\nILC: Trim analysis warning IL2046: Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.ThreeLevelsInheritance.Middle: Member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.ThreeLevelsInheritance.Base.M()' with 'RequiresUnreferencedCodeAttribute' implements interface member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.INoRuc.M()' without 'RequiresUnreferencedCodeAttribute'. 'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides.\nILC: Trim analysis warning IL2046: Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.DerivedOverridesImplementingMethod.C.M(): Member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.DerivedOverridesImplementingMethod.C.M()' with 'RequiresUnreferencedCodeAttribute' implements interface member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.INoRuc.M()' without 'RequiresUnreferencedCodeAttribute'. 'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides.\nILC: Trim analysis warning IL2046: Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.DerivedOverridesImplementingMethod.D: Member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.DerivedOverridesImplementingMethod.C.M()' with 'RequiresUnreferencedCodeAttribute' implements interface member 'Mono.Linker.Tests.Cases.RequiresCapability.BaseProvidesInterfaceMethodRequiresMismatch.INoRuc.M()' without 'RequiresUnreferencedCodeAttribute'. 'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides.\nILC: Trim analysis warning IL2046: AbstractBaseWithNoMethodsImplementsInterface.Derived.M(): Interface member 'AbstractBaseWithNoMethodsImplementsInterface.I.M()' with 'RequiresUnreferencedCodeAttribute' has an implementation member 'AbstractBaseWithNoMethodsImplementsInterface.Derived.M()' without 'RequiresUnreferencedCodeAttribute'. 'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides.
      Stack Trace
         at Mono.Linker.Tests.TestCasesRunner.ResultChecker.VerifyLoggedMessages(AssemblyDefinition original, TrimmingTestLogger logger, Boolean checkRemainingErrors) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 364
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.AdditionalChecking(TrimmedTestCaseResult linkResult, AssemblyDefinition original) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 157
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.Check(TrimmedTestCaseResult testResult) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 70
   at Mono.Linker.Tests.TestCases.All.Run(String testName) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 156
   at Mono.Linker.Tests.TestCases.All.RequiresCapability(String t) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 97

      at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
      
at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Was this helpful? Yes No

View more details on Build Analysis