JIT: Added SVE `Prefetch*` APIs. #103094

TIHan · 2024-06-05T21:13:38Z

Contributes to #99957

Adds:

PrefetchBytes
PrefetchInt16
PrefetchInt32
PrefetchInt64

dotnet-issue-labeler · 2024-06-05T21:13:43Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-issue-labeler · 2024-06-05T21:13:45Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan · 2024-06-05T21:14:59Z

src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

@@ -4940,6 +4945,22 @@ public enum SveMaskPattern : byte
        LargestMultipleOf3 = 30,  // The largest multiple of 3.
        All  = 31                 // All available (implicitly a multiple of two).
    };
+
+    public enum SvePrefetchType : byte


@kunalspathak @tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.

I see a note here about they not approved? @tannergooding can you confirm?

#94006 (comment)

#97831 approved the Prefetch* APIs.

The enum should have been approved as part of that, but wasn't looked at directly.

The enum names are different and were approved in #94007 (comment)

@TIHan - can you update the names accordingly?

TIHan · 2024-06-05T21:16:28Z

@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.

===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

dotnet-policy-service · 2024-06-05T21:17:58Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

kunalspathak

added some comments.

kunalspathak · 2024-06-05T22:50:31Z

src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs

@@ -4940,6 +4945,22 @@ public enum SveMaskPattern : byte
        LargestMultipleOf3 = 30,  // The largest multiple of 3.
        All  = 31                 // All available (implicitly a multiple of two).
    };
+
+    public enum SvePrefetchType : byte


I see a note here about they not approved? @tannergooding can you confirm?

#94006 (comment)

src/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

kunalspathak · 2024-06-06T00:26:45Z

also, need to handle immediate value and table generation logic.

kunalspathak · 2024-06-06T00:40:16Z

@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

a74nh · 2024-06-06T10:48:10Z

@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?

I'm not sure if there is anything we can test for. We can't read the setting back from the system.

also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.

Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.

src/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template

TIHan · 2024-06-06T17:51:08Z

@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.

See the original PR: #98468

a74nh · 2024-06-07T07:35:52Z

@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.

See the original PR: #98468

Depends how you define valid :)
They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.

src/coreclr/jit/hwintrinsiccodegenarm64.cpp

src/coreclr/jit/rationalize.cpp

TIHan · 2024-06-11T21:05:29Z

@kunalspathak this is ready again.

#103288 will need to be merged first before this one.

kunalspathak

There is some left over code that I don't think is needed. Also we should generalize the test template.

src/coreclr/jit/fgdiagnostic.cpp

src/coreclr/jit/gentree.cpp

src/coreclr/jit/hwintrinsiclistarm64sve.h

src/coreclr/jit/lsraarm64.cpp

src/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template

kunalspathak

LGTM. Thanks!

TIHan · 2024-06-12T15:41:39Z

Woo!

TIHan added 3 commits June 5, 2024 10:45

Initial APIs

6740334

Added SvePrefetch test template. Prefetch APIs now have special codegen.

597490a

Merging with main

5c66924

dotnet-issue-labeler bot added area-System.Runtime.Intrinsics new-api-needs-documentation labels Jun 5, 2024

TIHan commented Jun 5, 2024

View reviewed changes

dotnet-policy-service bot assigned TIHan Jun 5, 2024

TIHan force-pushed the sve-prefect-apis branch from c7b382d to 5c66924 Compare June 5, 2024 21:26

Minor cleanup

5954a3a

kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jun 5, 2024

kunalspathak mentioned this pull request Jun 5, 2024

Arm64: Implement SVE APIs #99957

Closed

kunalspathak requested changes Jun 5, 2024

View reviewed changes

TIHan added 2 commits June 5, 2024 19:28

Feedback

29b0a54

Some cleanup

a3c548f

This was referenced Jun 6, 2024

Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070

Open

[browser][MT] System.Net.Http.Functional.Tests.WorkItemExecution timeout #102385

Closed

kunalspathak reviewed Jun 6, 2024

View reviewed changes

src/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template Outdated Show resolved Hide resolved

TIHan added 3 commits June 10, 2024 17:19

Merge remote-tracking branch 'upstream/main' into sve-prefect-apis

73e5035

More work

fc64346

Tests pass

2f4db44

TIHan commented Jun 11, 2024

View reviewed changes

src/coreclr/jit/hwintrinsiccodegenarm64.cpp Outdated Show resolved Hide resolved

Revert changes

086ebd3

build-analysis bot mentioned this pull request Jun 11, 2024

[browser][ST] Wasm tests timeout #103246

Closed

tannergooding reviewed Jun 11, 2024

View reviewed changes

src/coreclr/jit/rationalize.cpp Outdated Show resolved Hide resolved

tannergooding mentioned this pull request Jun 11, 2024

Share more of the TYP_MASK handling and support rewriting TYP_MASK operands in rationalization #103288

Merged

TIHan force-pushed the sve-prefect-apis branch from a5d2203 to 086ebd3 Compare June 11, 2024 18:18

TIHan added 4 commits June 11, 2024 11:19

put back

6d803d2

Merged

463febe

Fix merge

7785abb

Fixing enum type

756624f

TIHan added 2 commits June 11, 2024 14:06

Quick test fix

dd10b10

Fix api

06ca1da

kunalspathak requested changes Jun 11, 2024

View reviewed changes

TIHan added 4 commits June 11, 2024 15:18

Feedback

115b282

Feedback

1e41770

Feedback - testing prefetch types

351acfb

load fix

6c11287

This was referenced Jun 12, 2024

NativeAOT legs timing out in CI #102239

Closed

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

kunalspathak approved these changes Jun 12, 2024

View reviewed changes

TIHan merged commit be2827c into dotnet:main Jun 12, 2024
163 of 167 checks passed

github-actions bot locked and limited conversation to collaborators Jul 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JIT: Added SVE `Prefetch*` APIs. #103094

JIT: Added SVE `Prefetch*` APIs. #103094

TIHan commented Jun 5, 2024

dotnet-issue-labeler bot commented Jun 5, 2024

dotnet-issue-labeler bot commented Jun 5, 2024

TIHan Jun 5, 2024 •

edited

Loading

kunalspathak Jun 5, 2024

a74nh Jun 6, 2024

kunalspathak Jun 7, 2024

kunalspathak Jun 7, 2024

TIHan commented Jun 5, 2024

dotnet-policy-service bot commented Jun 5, 2024

kunalspathak left a comment

kunalspathak Jun 5, 2024

kunalspathak commented Jun 6, 2024

kunalspathak commented Jun 6, 2024

a74nh commented Jun 6, 2024

TIHan commented Jun 6, 2024 •

edited

Loading

a74nh commented Jun 7, 2024

TIHan commented Jun 11, 2024

kunalspathak left a comment

kunalspathak left a comment

TIHan commented Jun 12, 2024

JIT: Added SVE Prefetch* APIs. #103094

JIT: Added SVE Prefetch* APIs. #103094

Conversation

TIHan commented Jun 5, 2024

dotnet-issue-labeler bot commented Jun 5, 2024

dotnet-issue-labeler bot commented Jun 5, 2024

TIHan Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

kunalspathak Jun 5, 2024

Choose a reason for hiding this comment

a74nh Jun 6, 2024

Choose a reason for hiding this comment

kunalspathak Jun 7, 2024

Choose a reason for hiding this comment

kunalspathak Jun 7, 2024

Choose a reason for hiding this comment

TIHan commented Jun 5, 2024

dotnet-policy-service bot commented Jun 5, 2024

kunalspathak left a comment

Choose a reason for hiding this comment

kunalspathak Jun 5, 2024

Choose a reason for hiding this comment

kunalspathak commented Jun 6, 2024

kunalspathak commented Jun 6, 2024

a74nh commented Jun 6, 2024

TIHan commented Jun 6, 2024 • edited Loading

a74nh commented Jun 7, 2024

TIHan commented Jun 11, 2024

kunalspathak left a comment

Choose a reason for hiding this comment

kunalspathak left a comment

Choose a reason for hiding this comment

TIHan commented Jun 12, 2024

JIT: Added SVE `Prefetch*` APIs. #103094

JIT: Added SVE `Prefetch*` APIs. #103094

TIHan Jun 5, 2024 •

edited

Loading

TIHan commented Jun 6, 2024 •

edited

Loading