ARM64-SVE: Saturating*ByActiveElementCount #102994

a74nh · 2024-06-03T14:00:35Z

No description provided.

dotnet-issue-labeler · 2024-06-03T14:00:40Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-03T14:01:05Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

a74nh · 2024-06-03T14:01:51Z

Stress:

❯ ~/stress_tester.py $CORE_ROOT/corerun ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll Sve_SaturatingDecrementByActiveElementCount
Starting test: /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll Sve_SaturatingDecrementByActiveElementCount
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_int_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_int_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_int_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_int_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_long_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_long_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_long_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_long_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_uint_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_uint_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_uint_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_uint_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_ulong_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_ulong_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_ulong_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_ulong_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_short() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_int() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_long() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_ulong() : 7
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingDecrementByActiveElementCount<UInt64>(Vector<UInt64>, Vector<UInt64>): RunBasicScenario_Load failed:
    left: (9950131736413655575, 4465441822095806569)
   right: (0, 1)
  result: (9950131736413655575, 4465441822095806569)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingDecrementByActiveElementCount_vector_ulong() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingDecrementByActiveElementCount.vector.ulong.cs:line 62
   at Program.<<Main>$>g__TestExecutor3132|0_3133(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 78555
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

❯ ~/stress_tester.py $CORE_ROOT/corerun ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll Sve_SaturatingIncrementByActiveElementCount
Starting test: /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/linux.arm64.Checked/Tests/Core_Root/corerun ./artifacts/tests/coreclr/linux.arm64.Checked/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/HardwareIntrinsics_Arm_ro.dll Sve_SaturatingIncrementByActiveElementCount
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_int_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_int_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_int_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_int_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_long_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_long_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_long_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_long_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_uint_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_uint_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_uint_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_uint_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_ulong_byte() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_ulong_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_ulong_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_ulong_ulong() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_short() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_long() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_ushort() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_uint() : 7
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_ulong() : 7
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (44330901, 80409478, 1977730174, 549934082)
   right: (1, 0, 1, 1)
  result: (44330901, 80409478, 1977730174, 549934082)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (292303989, 378338709, 953996304, 798366385)
   right: (0, 0, 1, 0)
  result: (292303989, 378338709, 953996304, 798366385)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (819467066, 249429381, 2062736168, 1442643265)
   right: (1, 0, 1, 0)
  result: (819467066, 249429381, 2062736168, 1442643265)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (951174538, 1165765203, 1616542767, 802986616)
   right: (1, 0, 1, 0)
  result: (951174538, 1165765203, 1616542767, 802986616)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (249578136, 705899262, 1558623224, 409752869)
   right: (0, 1, 1, 0)
  result: (249578136, 705899262, 1558623224, 409752869)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (717855585, 241806690, 78452716, 878696978)
   right: (0, 0, 1, 0)
  result: (717855585, 241806690, 78452716, 878696978)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (1862105264, 1666216739, 1862619847, 691182071)
   right: (1, 0, 1, 1)
  result: (1862105264, 1666216739, 1862619847, 691182071)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------
Test failed:
..........................................
..........................................
Sve.SaturatingIncrementByActiveElementCount<Int32>(Vector<Int32>, Vector<Int32>): RunBasicScenario_Load failed:
    left: (90343983, 830076347, 711978603, 906125867)
   right: (0, 0, 0, 1)
  result: (90343983, 830076347, 711978603, 906125867)
..........................................
System.Exception: One or more scenarios did not complete as expected.
   at JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_SaturatingIncrementByActiveElementCount_vector_int() in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/Arm/Sve/Sve_ro/Sve_ro/gen/Sve.SaturatingIncrementByActiveElementCount.vector.int.cs:line 62
   at Program.<<Main>$>g__TestExecutor3172|0_3173(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&) in /home/alahay01/dotnet/runtime_sve_api/artifacts/tests/coreclr/obj/linux.arm64.Checked/Managed/JIT/HardwareIntrinsics/HardwareIntrinsics_Arm_ro/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 79515

Need to check if these are known issues.

a74nh · 2024-06-03T14:02:28Z

@dotnet/arm64-contrib @kunalspathak

kunalspathak

Looks good, except a question.

kunalspathak · 2024-06-04T05:27:23Z

src/coreclr/jit/hwintrinsiccodegenarm64.cpp

+                }
+
+                // Switch instruction if arg1 is unsigned.
+                if (varTypeIsUnsigned(node->GetAuxiliaryType()))


shouldn't this also use the unsigned variant of the instruction i.e. the first arg is Vector<ulong> and hence, the base type is ulong.

public static System.Numerics.Vector<ulong> SaturatingDecrementByActiveElementCount(System.Numerics.Vector<ulong> value, System.Numerics.Vector<ulong> from) { throw null; }

Aux type is set as:
retNode->AsHWIntrinsic()->SetAuxiliaryJitType(op1BaseJitType);

So, for the example, GetAuxiliaryType() should be returning ulong

kunalspathak

LGTM. Can you fix the formatting errors too?

a74nh · 2024-06-04T14:19:24Z

LGTM. Can you fix the formatting errors too?

Done.

kunalspathak · 2024-06-04T16:42:12Z

@a74nh - there is a merge conflict.

kunalspathak · 2024-06-05T12:47:11Z

src/tests/JIT/HardwareIntrinsics/Arm/Shared/Helpers.cs

+                acc += (mask[i] == 1) ? 1 : 0;
+            }
+            return acc;
+


Missing } is causing build failure.

kunalspathak · 2024-06-05T17:15:46Z

/ba-g superpmi-replay failures are #102773 and machine agent issue

ARM64-SVE: Saturating*ByActiveElementCount

0387a0b

dotnet-issue-labeler bot added area-System.Runtime.Intrinsics new-api-needs-documentation labels Jun 3, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 3, 2024

a74nh marked this pull request as ready for review June 3, 2024 14:02

kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jun 3, 2024

kunalspathak mentioned this pull request Jun 3, 2024

Arm64: Implement SVE APIs #99957

Closed

build-analysis bot mentioned this pull request Jun 3, 2024

[WASM] browser-wasm tests fail with "Cannot box IsByRefLike type" #102988

Closed

kunalspathak reviewed Jun 4, 2024

View reviewed changes

kunalspathak approved these changes Jun 4, 2024

View reviewed changes

formatting

2a2276d

This was referenced Jun 4, 2024

GC\Regressions\v2.0-beta2\452950\452950\452950.cmd failing on Mono minijit Windows x64 #99729

Open

at GC_Regressions._v2_0_beta2_452950_452950_452950_._v2_0_beta2_452950_452950_452950_cmd() #100174

Closed

NativeAOT legs timing out in CI #102239

Closed

Merge main

0de3db0

kunalspathak reviewed Jun 5, 2024

View reviewed changes

Missing bracket

c727e44

build-analysis bot mentioned this pull request Jun 5, 2024

CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062

Open

kunalspathak merged commit 08056f9 into dotnet:main Jun 5, 2024
162 of 167 checks passed

a74nh deleted the SaturatingDecrementByActive_github branch June 13, 2024 10:40

github-actions bot locked and limited conversation to collaborators Jul 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM64-SVE: Saturating*ByActiveElementCount #102994

ARM64-SVE: Saturating*ByActiveElementCount #102994

a74nh commented Jun 3, 2024

dotnet-issue-labeler bot commented Jun 3, 2024

dotnet-policy-service bot commented Jun 3, 2024

a74nh commented Jun 3, 2024

a74nh commented Jun 3, 2024

kunalspathak left a comment

kunalspathak Jun 4, 2024

a74nh Jun 4, 2024

kunalspathak Jun 4, 2024

kunalspathak left a comment

a74nh commented Jun 4, 2024

kunalspathak commented Jun 4, 2024

kunalspathak Jun 5, 2024

a74nh Jun 5, 2024

kunalspathak commented Jun 5, 2024

ARM64-SVE: Saturating*ByActiveElementCount #102994

ARM64-SVE: Saturating*ByActiveElementCount #102994

Conversation

a74nh commented Jun 3, 2024

dotnet-issue-labeler bot commented Jun 3, 2024

dotnet-policy-service bot commented Jun 3, 2024

a74nh commented Jun 3, 2024

a74nh commented Jun 3, 2024

kunalspathak left a comment

Choose a reason for hiding this comment

kunalspathak Jun 4, 2024

Choose a reason for hiding this comment

a74nh Jun 4, 2024

Choose a reason for hiding this comment

kunalspathak Jun 4, 2024

Choose a reason for hiding this comment

kunalspathak left a comment

Choose a reason for hiding this comment

a74nh commented Jun 4, 2024

kunalspathak commented Jun 4, 2024

kunalspathak Jun 5, 2024

Choose a reason for hiding this comment

a74nh Jun 5, 2024

Choose a reason for hiding this comment

kunalspathak commented Jun 5, 2024