-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Backport 1ES templates #102681
Merged
eduardo-vp
merged 10 commits into
dotnet:release/8.0-staging
from
eduardo-vp:backport-1es-templates
May 29, 2024
Merged
[release/8.0-staging] Backport 1ES templates #102681
eduardo-vp
merged 10 commits into
dotnet:release/8.0-staging
from
eduardo-vp:backport-1es-templates
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mage (dotnet#91019) * Use host rootfs when TARGET_BUILD_ARCH matches
* Start moving over to official templates * Parameterize runtime-inner-loop * Use default false for isOfficialBuild in pipeline-with-resources * Respond to PR comments * Code review comments * Use default template args
Import pool-providers in common variables. This should allow all stages access to the pool provider variables.
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 25, 2024
eduardo-vp
added
area-Infrastructure
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 25, 2024
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
eduardo-vp
force-pushed
the
backport-1es-templates
branch
from
May 28, 2024 23:06
94793ad
to
0f15d9e
Compare
jkoritzinsky
approved these changes
May 29, 2024
jeffschwMSFT
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can consider this as a tell mode change
eduardo-vp
added
Servicing-approved
Approved for servicing release
and removed
Servicing-consider
Issue for next servicing release review
labels
May 29, 2024
eduardo-vp
merged commit May 29, 2024
32400f6
into
dotnet:release/8.0-staging
179 of 183 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly backports #99433 (the 1ES templates).
The changes that were needed with this PR were cherry-picked for clarity. Also, as originally the maximum YAML size was exceeded in the runtime pipeline, the linux_x86, tizen_armel, and freebsd_x64 jobs were moved to the global-build pipeline.
Official build link (0f15d9e): https://dev.azure.com/dnceng/internal/_build/results?buildId=2462127&view=results
Cc @jkoritzinsky @agocke @amanasifkhalid