Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup VARIANT marshalling and convert to managed #102498

Merged
merged 48 commits into from
Aug 28, 2024
Merged

Cleanup VARIANT marshalling and convert to managed #102498

merged 48 commits into from
Aug 28, 2024

Commits on May 15, 2024

  1. Handle simple cases of MarshalComVariantForOleVariant

    @huoyaoyuan
    huoyaoyuan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9ebbfc5 View commit details
    Browse the repository at this point in the history

  2. Pseudo code for MarshalOleVariantForComVariant

    @huoyaoyuan
    huoyaoyuan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7c35e76 View commit details
    Browse the repository at this point in the history

  3. Complete and setup managed call for MarshalObjectForOleVariant

    @huoyaoyuan
    huoyaoyuan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2b7b42b View commit details
    Browse the repository at this point in the history

  4. Setup MarshalHelperConvertObjectToVariant except record

    @huoyaoyuan
    huoyaoyuan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b7b73dd View commit details
    Browse the repository at this point in the history

  5. Setup MarshalHelperCastVariant

    @huoyaoyuan
    huoyaoyuan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c9b06fe View commit details
    Browse the repository at this point in the history

  6. Cleanup Variant struct and FCall

    @huoyaoyuan
    huoyaoyuan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fcd2cff View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Handle record case

    @huoyaoyuan
    huoyaoyuan committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c193137 View commit details
    Browse the repository at this point in the history

  2. Cleanup VariantOleToCom/VariantComToOle routines

    @huoyaoyuan
    huoyaoyuan committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fb34d6d View commit details
    Browse the repository at this point in the history

  3. Remove VariantData definition at unmanaged side

    @huoyaoyuan
    huoyaoyuan committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4ba8412 View commit details
    Browse the repository at this point in the history

  4. Eliminate a dead branch for ref

    @huoyaoyuan
    huoyaoyuan committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e38f65c View commit details
    Browse the repository at this point in the history

  5. Remove CVTypes in native

    @huoyaoyuan
    huoyaoyuan committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8be5299 View commit details
    Browse the repository at this point in the history

  6. Share GetComIPFromObjectRef

    @huoyaoyuan
    huoyaoyuan committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f653d98 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Add tests for managed to native side

    @huoyaoyuan
    huoyaoyuan committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0af450d View commit details
    Browse the repository at this point in the history

  2. Add test for native to managed side

    @huoyaoyuan
    huoyaoyuan committed May 17, 2024
    Configuration menu
    Copy the full SHA
    dbd1c03 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Add test for byref returning to BYREF

    @huoyaoyuan
    huoyaoyuan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8409346 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'variant-test' into variant-2

    @huoyaoyuan
    huoyaoyuan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    827ffec View commit details
    Browse the repository at this point in the history

  3. Fix BYREF handling

    @huoyaoyuan
    huoyaoyuan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    435dedd View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Fix array marshalling

    @huoyaoyuan
    huoyaoyuan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    eceed3f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fix record marshalling

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6d4ee35 View commit details
    Browse the repository at this point in the history

  2. Fix VT_VARIANT case

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    03a5f7f View commit details
    Browse the repository at this point in the history

  3. Cleanup and fix IUnknown case

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3ed9214 View commit details
    Browse the repository at this point in the history

  4. Add more test for VT_UNKNOWN

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3f509a1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'variant-test' into variant-2

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    57617e0 View commit details
    Browse the repository at this point in the history

  6. Cleanup for VT_VARIANT

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    faee4ec View commit details
    Browse the repository at this point in the history

  7. Cleanup SR and comment

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    99f6ef5 View commit details
    Browse the repository at this point in the history

  8. Fix contract in GetTypeHandleForVarType

    @huoyaoyuan
    huoyaoyuan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dcd0287 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Move VariantChangeTypeEx to coreclr

    @huoyaoyuan
    huoyaoyuan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e58937b View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Add unmanaged fast path for (U)Int64

    @huoyaoyuan
    huoyaoyuan committed May 25, 2024
    Configuration menu
    Copy the full SHA
    454c170 View commit details
    Browse the repository at this point in the history

  2. Make ComVariant immutable

    @huoyaoyuan
    huoyaoyuan committed May 25, 2024
    Configuration menu
    Copy the full SHA
    f2f71e7 View commit details
    Browse the repository at this point in the history

  3. Add GCPROTECT in ConvertSystemColorToOleColor

    @huoyaoyuan
    huoyaoyuan committed May 25, 2024
    Configuration menu
    Copy the full SHA
    04f6aad View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Fix variant init

    @huoyaoyuan
    huoyaoyuan committed May 26, 2024
    Configuration menu
    Copy the full SHA
    8da56dd View commit details
    Browse the repository at this point in the history

  2. Fix BYREF|EMPTY

    @huoyaoyuan
    huoyaoyuan committed May 26, 2024
    Configuration menu
    Copy the full SHA
    3c095a1 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge branch 'main' into variant-2

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    170fefc View commit details
    Browse the repository at this point in the history

  2. Initialize ComVariant

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d2381bf View commit details
    Browse the repository at this point in the history

  3. Move GCPROTECT to the QCall

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    b315d3a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'main' into variant-2

    @huoyaoyuan
    huoyaoyuan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    bf5a151 View commit details
    Browse the repository at this point in the history

  2. Pass UnknownWrapper through SetFieldsObject

    @huoyaoyuan
    huoyaoyuan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    68525c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <[email protected]>
    @huoyaoyuan @AaronRobinsonMSFT
    huoyaoyuan and AaronRobinsonMSFT authored Jun 1, 2024
    Configuration menu
    Copy the full SHA
    41ad24f View commit details
    Browse the repository at this point in the history

  2. Suggestions at native side

    @huoyaoyuan
    huoyaoyuan committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7a9b989 View commit details
    Browse the repository at this point in the history

  3. Rename ComIP

    @huoyaoyuan
    huoyaoyuan committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9cc8a38 View commit details
    Browse the repository at this point in the history

  4. Add comments for ConvertWrappedObject

    @huoyaoyuan
    huoyaoyuan committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    944b76a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Try convert to RECORD for all cases

    @huoyaoyuan
    huoyaoyuan committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    09af5b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main'

    @huoyaoyuan
    huoyaoyuan committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0ff823e View commit details
    Browse the repository at this point in the history

  2. Dispose Variant on failure

    @huoyaoyuan
    huoyaoyuan committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5dfda22 View commit details
    Browse the repository at this point in the history

  3. Update formatting

    @huoyaoyuan
    huoyaoyuan committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    545d597 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Fix NO_MAPPING definition

    @huoyaoyuan
    huoyaoyuan committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    fb32db0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'main'

    @huoyaoyuan
    huoyaoyuan committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b85abfa View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'main' into variant-2

    @AaronRobinsonMSFT
    AaronRobinsonMSFT authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    20506a5 View commit details
    Browse the repository at this point in the history