Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add System.Net.ServerSentEvents #102238

Merged
merged 3 commits into from
May 31, 2024
Merged

Add System.Net.ServerSentEvents #102238

merged 3 commits into from
May 31, 2024

Conversation

stephentoub
Copy link
Member

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels May 15, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@build-analysis build-analysis bot mentioned this pull request May 15, 2024
Open
@stephentoub stephentoub added area-System.IO blocking Marks issues that we want to fast track in order to unblock other important work and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners blocking Marks issues that we want to fast track in order to unblock other important work labels May 19, 2024
@stephentoub stephentoub changed the title Add System.Formats.Sse Add System.Net.ServerSentEvents May 29, 2024
@stephentoub stephentoub marked this pull request as ready for review May 29, 2024 01:35
@stephentoub stephentoub added this to the 9.0.0 milestone May 29, 2024
@stephentoub
Copy link
Member Author

@MihaZupan, would you be able to help with a code review here?

MihaZupan
MihaZupan approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buffer offsets are a bit hard to follow so I'd consider using ArrayBuffer.

Otherwise LGTM

src/libraries/System.Net.ServerSentEvents/src/PACKAGE.md Outdated Show resolved Hide resolved
src/libraries/System.Net.ServerSentEvents/src/Resources/Strings.resx Outdated Show resolved Hide resolved
src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser_1.cs Show resolved Hide resolved
src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser_1.cs Show resolved Hide resolved
src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser_1.cs Show resolved Hide resolved
src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser_1.cs Show resolved Hide resolved
src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser_1.cs Show resolved Hide resolved
@stephentoub
Copy link
Member Author

Thanks for the review, @MihaZupan.

@stephentoub stephentoub merged commit 2298795 into dotnet:main May 31, 2024
84 checks passed
@stephentoub stephentoub deleted the sseparser branch May 31, 2024 16:32
@captainsafia captainsafia mentioned this pull request Jun 10, 2024
Open
@ellahathaway ellahathaway mentioned this pull request Jun 11, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@annelo-msft annelo-msft annelo-msft left review comments

Assignees

@stephentoub stephentoub

Labels
area-System.Net new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Support parsing server-sent events (SSE)
3 participants
@stephentoub @annelo-msft @MihaZupan