Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mono.Linker.Tests build #102102

Merged
merged 1 commit into from
May 11, 2024
Merged

Fix Mono.Linker.Tests build #102102

merged 1 commit into from
May 11, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented May 10, 2024

And ensure changes to ProjectReferences trigger linker tests.

The Mono.Linker.Tests build was broken by #102036 but we didn't catch it because we didn't trigger the illink test run for that change.

And ensure changes to ProjectReferences trigger linker tests
@sbomer sbomer requested review from jkotas and jtschuster May 10, 2024 22:30
@sbomer sbomer requested a review from marek-safar as a code owner May 10, 2024 22:30
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 10, 2024
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 31527d1 into dotnet:main May 11, 2024
76 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
And ensure changes to ProjectReferences trigger linker tests
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants