Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target NetCoreAppToolCurrent in ILC test projects #102058

Conversation

PaulusParssinen
Copy link
Contributor

Just testing if anything explodes if we target current .NET in these test projects. Came across these when hunting .NET Standard projects that pull in NativeFormatReader and stuff.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 9, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member

This looks good to me since the CI passed. But for posterity's sake, what problem does this solve?

@PaulusParssinen
Copy link
Contributor Author

PaulusParssinen commented May 10, 2024

what problem does this solve?

Right. I often find myself going through Common code that is often untouched from its original CoreRT state where newer high-performance APIs such as BinaryPrimitives/BitOperations could be used. Partly out of curiosity, these two test projects surprised me as being NS2.0 targets, is there some background/history why theres a lot of ILC adjacent projects with NS2.0 targets where as majority of the tooling is latest .NET?

And whether stuff like this is still relevant?

#if NETFX_45
byte[] bytes = new byte[numBytes];
for (int i = 0; i < bytes.Length; i++)
bytes[i] = *(_base + offset + i);
value = Encoding.UTF8.GetString(bytes, 0, bytes.Length);
#else

It's up to code owner to decide whether this is valuable at all, I don't feel strogly in either case 😅

@MichalStrehovsky MichalStrehovsky merged commit 0e46919 into dotnet:main May 13, 2024
85 of 87 checks passed
@PaulusParssinen PaulusParssinen deleted the target-netcoreapptoolcurrent-in-ilc-tests branch May 13, 2024 13:04
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants