Add top-level controls for VMR to enable/disable system lbiraries #101797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier for the VMR to pass top-level options to let the runtime use bundled/vendored (`external`) vs system versions of libraries.
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
omajid
commented
May 2, 2024
| @@ -53,6 +53,13 @@ | |||
| <InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)verbosity $(LogVerbosity)</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)nodereuse $(ArcadeFalseBoolBuildArg)</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg)</InnerBuildArgs> | |||
|
|
|||
| <InnerBuildArgs Condition="'$(UseSystemBrotli)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=$(UseSystemBrotli)</InnerBuildArgs> | |||
There was a problem hiding this comment.
omajid
commented
May 2, 2024
| <InnerBuildArgs Condition="'$(UseSystemBrotli)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=$(UseSystemBrotli)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=$(UseSystemLibunwind)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemLlvmLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LLVM_LIBUNWIND=$(UseSystemLlvmLibunwind)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemRapidjson)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_RAPIDJSON=$(UseSystemRapidjson)</InnerBuildArgs> |
There was a problem hiding this comment.
Implemented by:
omajid
commented
May 2, 2024
| <InnerBuildArgs Condition="'$(UseSystemLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=$(UseSystemLibunwind)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemLlvmLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LLVM_LIBUNWIND=$(UseSystemLlvmLibunwind)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemRapidjson)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_RAPIDJSON=$(UseSystemRapidjson)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemZlib)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_ZLIB=$(UseSystemZlib)</InnerBuildArgs> |
omajid
commented
May 2, 2024
| @@ -53,6 +53,13 @@ | |||
| <InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)verbosity $(LogVerbosity)</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)nodereuse $(ArcadeFalseBoolBuildArg)</InnerBuildArgs> | |||
| <InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg)</InnerBuildArgs> | |||
|
|
|||
| <InnerBuildArgs Condition="'$(UseSystemBrotli)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=$(UseSystemBrotli)</InnerBuildArgs> | |||
| <InnerBuildArgs Condition="'$(UseSystemLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=$(UseSystemLibunwind)</InnerBuildArgs> | |||
There was a problem hiding this comment.
omajid
commented
May 2, 2024
|
|
||
| <InnerBuildArgs Condition="'$(UseSystemBrotli)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=$(UseSystemBrotli)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=$(UseSystemLibunwind)</InnerBuildArgs> | ||
| <InnerBuildArgs Condition="'$(UseSystemLlvmLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LLVM_LIBUNWIND=$(UseSystemLlvmLibunwind)</InnerBuildArgs> |
This was referenced May 2, 2024
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for the VMR to pass top-level options to let the runtime use bundled/vendored (
external) vs system versions of libraries.