Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typename parsing cleanup #101767

Merged
merged 3 commits into from
May 6, 2024
Merged

Typename parsing cleanup #101767

merged 3 commits into from
May 6, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 1, 2024

  • Remove unnecessary System.Type wrapper for type name parsing in tools. Create the type directly from the parsed name.
  • Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions with S.R.M.TypeNameParser
  • Move type name Unescape and Split helpers into dedicated helper type
  • Other cleanup

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

@jkotas
Typename parsing cleanup
e640e9a 
- Remove unnecessary System.Type wrapper for type name parsing in tools.
  Create the type directly from the parsed name.
- Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions
  with S.R.M.TypeNameParser
- Move type name Unescape and Split helpers into dedicated helper type
- Other cleanup
@jkotas jkotas marked this pull request as ready for review May 1, 2024 17:44
@jkotas jkotas requested a review from adamsitnik May 1, 2024 17:45
This was referenced May 1, 2024
Open
Closed
Closed
Closed
Open
Closed
@jkotas jkotas mentioned this pull request May 1, 2024
Open
@jkotas
Copy link
Member Author

jkotas commented May 1, 2024

@MichalStrehovsky Could you please review this PR when you get a chance? The type name parsing in the managed type system is the most substantial change. It sets up the ground for replacing AssemblyName with AssemblyNameInfo in the managed type system.

@jkotas
Copy link
Member Author

jkotas commented May 1, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky Could you please review this PR when you get a chance? The type name parsing in the managed type system is the most substantial change. It sets up the ground for replacing AssemblyName with AssemblyNameInfo in the managed type system.

There are test build failures, but otherwise looks reasonable to me, thanks for setting this towards a AssemblyNameInfo path!

@jkotas
Copy link
Member Author

jkotas commented May 2, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 2, 2024
Closed
Open
Open
Closed
buyaa-n
buyaa-n approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkotas jkotas merged commit 8a2e7e3 into dotnet:main May 6, 2024
146 of 149 checks passed
adamsitnik
adamsitnik reviewed May 6, 2024
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jkotas!

michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@jkotas @michaelgsharp
Typename parsing cleanup (dotnet#101767)
0e8eaa7 
- Remove unnecessary System.Type wrapper for type name parsing in tools.
  Create the type directly from the parsed name.
- Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions
  with S.R.M.TypeNameParser
- Move type name Unescape and Split helpers into dedicated helper type
- Other cleanup
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@jkotas @Ruihan-Yin
Typename parsing cleanup (dotnet#101767)
c8b6779 
- Remove unnecessary System.Type wrapper for type name parsing in tools.
  Create the type directly from the parsed name.
- Rename S.R.TypeNameParser to S.R.TypeNameResolver to avoid name collisions
  with S.R.M.TypeNameParser
- Move type name Unescape and Split helpers into dedicated helper type
- Other cleanup
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@jkotas jkotas deleted the resolver branch June 24, 2024 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik left review comments

@buyaa-n buyaa-n buyaa-n approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jkotas jkotas

Labels
area-System.Reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotas @MichalStrehovsky @adamsitnik @buyaa-n