Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] Read/store globals from contract descriptor #101450

Merged
merged 12 commits into from
Apr 26, 2024
Merged

[cdac] Read/store globals from contract descriptor #101450

merged 12 commits into from
Apr 26, 2024

Commits on Apr 23, 2024

  1. Check cdac_reader_init result

    @elinor-fung
    elinor-fung committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fc3dcf2 View commit details
    Browse the repository at this point in the history

  2. Store globals from contract descriptor

    @elinor-fung
    elinor-fung committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fda47d3 View commit details
    Browse the repository at this point in the history

  3. Read SOSBreakingChangeVersion from globals

    @elinor-fung
    elinor-fung committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0700338 View commit details
    Browse the repository at this point in the history

  4. Read global pointer

    @elinor-fung
    elinor-fung committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a01b167 View commit details
    Browse the repository at this point in the history

  5. Add tests for reading global value

    @elinor-fung
    elinor-fung committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8527355 View commit details
    Browse the repository at this point in the history

  6. Add tests for reading indirect global value

    @elinor-fung
    elinor-fung committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7f77200 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Move calling init into CDAC::Create

    @elinor-fung
    elinor-fung committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c7bc9aa View commit details
    Browse the repository at this point in the history

  2. Use generic with IBinaryInteger constraint

    @elinor-fung
    elinor-fung committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    03ab101 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <[email protected]>
    @elinor-fung @AaronRobinsonMSFT
    elinor-fung and AaronRobinsonMSFT authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7c773e9 View commit details
    Browse the repository at this point in the history

  4. Replace [Try]Read* with generic [Try]Read for numbers

    @elinor-fung
    elinor-fung committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    125608f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <[email protected]>
    @elinor-fung @AaronRobinsonMSFT
    elinor-fung and AaronRobinsonMSFT authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c142884 View commit details
    Browse the repository at this point in the history

  2. Add caller info to asserts in test

    @elinor-fung
    elinor-fung committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    28dc125 View commit details
    Browse the repository at this point in the history