Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #101379

Merged
merged 9 commits into from
May 6, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 22, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/installer

  • Subscription: 2a4e5111-6978-401f-68a5-08dba3b24dbe
  • Build: 20240503.16
  • Date Produced: May 3, 2024 7:05:39 PM UTC
  • Commit: fa261b952d702c6bd604728fcbdb58ac071a22b1
  • Branch: refs/heads/main

…240421.5

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.4.24221.5
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Apr 22, 2024
…240421.5

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.4.24221.5
…240429.2

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24229.2
@lewing
Copy link
Member

lewing commented May 3, 2024

./RunTests.sh: line 94:    79 Segmentation fault      (core dumped) dotnet exec xunit.console.dll Wasm.Build.Tests.dll -xml $XHARNESS_OUT/testResults.xml $HELIX_XUNIT_ARGS -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing $XUnitTraitArg $RSP_FILE

I'm merging main again but that is a non wasm runtime/xunit bug @jeffschwMSFT

@jeffschwMSFT
Copy link
Member

@mangod9 can you take a look? thanks

@mangod9
Copy link
Member

mangod9 commented May 3, 2024

Hi @lewing, could you please point me to the link for the dump?

@mangod9
Copy link
Member

mangod9 commented May 3, 2024

Thanks. Here is the stack of the failure. Perhaps related to #101695 -- @dotnet/jit-contrib ?

00 libclrjit!Compiler::optCompactLoop
01 libclrjit!Compiler::optFindLoops
02 libclrjit!Compiler::optFindLoopsPhase
03 libclrjit!jitNativeCode
04 libclrjit!CILJit::compileMethod
05 libcoreclr!invokeCompileMethodHelper
06 libcoreclr!invokeCompileMethod
07 libcoreclr!UnsafeJitFunction
08 libcoreclr!MethodDesc::JitCompileCodeLocked
09 libcoreclr!MethodDesc::JitCompileCodeLockedEventWrapper
0a libcoreclr!MethodDesc::JitCompileCode
0b libcoreclr!MethodDesc::PrepareILBasedCode
0c libcoreclr!TieredCompilationManager::CompileCodeVersion
0d libcoreclr!TieredCompilationManager::DoBackgroundWork
0e libcoreclr!TieredCompilationManager::BackgroundWorkerStart
0f libcoreclr!TieredCompilationManager::BackgroundWorkerBootstrapper1
10 libcoreclr!ZL31ManagedThreadBase_DispatchOuterP22ManagedThreadCallState
11 libcoreclr!ManagedThreadBase::KickOff
12 libcoreclr!TieredCompilationManager::BackgroundWorkerBootstrapper0
13 libcoreclr!CorUnix::CPalThread::ThreadEntry

@AndyAyersMS
Copy link
Member

Yeah very likely the bug we just fixed. Can we update the 9P5 bits?

@mangod9
Copy link
Member

mangod9 commented May 3, 2024

The change seems to be picking up 9.0.100-preview.5.24229.2 but guessing we need something later than that?

@AndyAyersMS
Copy link
Member

I think so. The fix is here #101714 so you likely need something stamped 24230 or maybe even one day later (goes up by 50 each month, right? so maybe 24250+).

@mangod9
Copy link
Member

mangod9 commented May 3, 2024

@lewing would `dotnet-maestro' pickup a newer build automagically or does it need a hand update?

dotnet-maestro bot and others added 2 commits May 3, 2024 18:47
…240503.12

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24253.12
@lewing
Copy link
Member

lewing commented May 3, 2024

I triggered new flow and merged main

@lewing
Copy link
Member

lewing commented May 3, 2024

@lewing would `dotnet-maestro' pickup a newer build automagically or does it need a hand update?

The darc subscription is set to run weekly so I manually triggered it with
darc trigger-subscriptions --ids 2a4e5111-6978-401f-68a5-08dba3b24dbe
The subscription id is listed in the description for flow prs which makes it easy to trigger again. If I need to look up a subscription I typically use darc get-subscriptions with various args

@mangod9
Copy link
Member

mangod9 commented May 3, 2024

sounds good. Hoping it makes progress with latest.

@mangod9
Copy link
Member

mangod9 commented May 3, 2024

Appears to be still failing. Looking at the latest dump the libclrjit version changed from 9.0.0-preview.4.24223.11 to 9.0.0-preview.4.24225.8.

@AndyAyersMS
Copy link
Member

I believe there are still issues being sorted to get a new 9P4 build out (partially because of this jit issue, which is fixed in that work), so maybe we're lagging behind in integrating runtime bits? @mmitche any ETA on a newer 9P4?

…240503.16

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24253.16
@mangod9
Copy link
Member

mangod9 commented May 6, 2024

Looks like the only failure is a known failure in System.Security.Cryptography.X509Certificates.Tests.ChainTests. Perhaps good to merge?

@lewing lewing merged commit 4a676e2 into main May 6, 2024
154 of 156 checks passed
@lewing lewing deleted the darc-main-deddb4c6-e4e3-473a-8bbf-1ad7e3090121 branch May 6, 2024 17:12
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
* Update dependencies from https://github.com/dotnet/installer build 20240421.5

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.4.24221.5

* Update dependencies from https://github.com/dotnet/installer build 20240421.5

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.4.24221.5

* Update dependencies from https://github.com/dotnet/installer build 20240429.2

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24229.2

* Update dependencies from https://github.com/dotnet/installer build 20240503.12

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24253.12

* Update dependencies from https://github.com/dotnet/installer build 20240503.16

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24253.16

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <[email protected]>
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Update dependencies from https://github.com/dotnet/installer build 20240421.5

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.4.24221.5

* Update dependencies from https://github.com/dotnet/installer build 20240421.5

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.4.24221.5

* Update dependencies from https://github.com/dotnet/installer build 20240429.2

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24229.2

* Update dependencies from https://github.com/dotnet/installer build 20240503.12

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24253.12

* Update dependencies from https://github.com/dotnet/installer build 20240503.16

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.4.24215.2 -> To Version 9.0.100-preview.5.24253.16

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants