Allow user to specify a rundown keyword to override the default. #101189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
approved these changes
Apr 19, 2024
cshung
force-pushed
the
public/specify-rundown-keyword
branch
from
a423c94
to
0eac56c
Compare
Co-authored-by: Noah Falk <[email protected]>
cshung
force-pushed
the
public/specify-rundown-keyword
branch
from
0eac56c
to
450154e
Compare
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…net#101189) Co-authored-by: Noah Falk <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows user to specify a rundown keyword to override the default. Using a newly introduced
EP_COMMANDID_COLLECT_TRACING_4, the user can specify a rundown keyword and let the rundown process to use that.The capability will be leveraged by dotnet/diagnostics#4615 to allow collecting only the
GCSettingsEventfor gc-collect profile.Fixes #100871