[release/8.0-staging] Fix native leak in CryptoNative_GetX509nameInfo #100793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…the contents of the stack. This change fixes not freeing the individual GENERAL_NAME items.
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
3 tasks
bartonjs
approved these changes
Apr 10, 2024
leecow
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #100780 to release/8.0-staging
/cc @vcsjones
Customer Impact
Reported by a customer in #99933. Customers using the X509Certificate2.GetNameInfo API on Linux may leak native memory which is never freed, leading to resource starvation.
Regression
Testing
The fix was tested by observing the memory usage of the affected API in a loop and seeing that native resources were being freed appropriately.
Risk
Low. The fix is to use the correct API to free the native resource, and the correct API is used elsewhere in the native shim, so its behavior is understood.