-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console.Unix: revert SetWindowSize implementation. #100272
Conversation
SetWindowSize was implemented using using TIOCSWINSZ. TIOCSWINSZ is meant to inform the kernel of the terminal size. The window that shows the terminal doesn't change to match that size.
Note regarding the
|
@stephentoub do you have additional feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/area-system-console, can you please review, in particular for the concept of the change?
@dotnet/area-system-console is this good to merge? |
@adamsitnik ptal. |
@jozkee Please review this. We should get this into RC1. |
<Target>P:System.Console.WindowWidth:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/mscorlib.dll</Left> | ||
<Right>net9.0/mscorlib.dll</Right> | ||
</Suppression> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this generated? I tried as described in #75824 (comment) but didn't get any changes related to Console.
cc @ericstj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet.cmd src/libraries/apicompat --no-dependencies /p:ApiCompatGenerateSuppressionFile=true
should work, make sure you've built libs before doing that.
I think the comment you linked to had a different property name. The one listed in the error message and shared here should be the right one: ApiCompatGenerateSuppressionFile
https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#apicompatgeneratesuppressionfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also these are all CP0014 - they are what I'd expect for the attribute changes to the reference assembly. If you're OK with those changes then these are fine (so long as build passes they are in sync).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking them out. Btw, this is what I get from running dotnet.cmd:
C:\git\runtime>dotnet.cmd src\libraries\apicompat --no-dependencies /p:ApiCompatGenerateSuppressionFile=true
C:\Program Files\dotnet
Could not execute because the specified command or file was not found.
Possible reasons for this include:
* You misspelled a built-in dotnet command.
* You intended to execute a .NET program, but dotnet-src\libraries\apicompat does not exist.
* You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.
SetWindowSize was implemented using using TIOCSWINSZ.
TIOCSWINSZ is meant to inform the kernel of the terminal size.
The window that shows the terminal doesn't change to match that size.
Fixes #96208.
@dotnet/area-system-console ptal.