-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more information and events to System.Net.Http telemetry #85729
Labels
area-System.Net.Http
enhancement
Product code improvement that does NOT require public API changes/additions
Milestone
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsMoving the remaining items out of #83734 to make tracking easier (the changes in the original issue were backported to 6.0 and 7.0). We should consider including more information in the
|
carlossanlop
added a commit
to carlossanlop/runtime
that referenced
this issue
May 8, 2023
Adding more details to our servicing documentation, particularly around the check-servicing-labels CI leg. Co-authored-by: Juan Hoyos <[email protected]>
carlossanlop
added a commit
that referenced
this issue
May 9, 2023
Adding more details to our servicing documentation, particularly around the check-servicing-labels CI leg. Co-authored-by: Juan Hoyos <[email protected]>
ghost
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Jul 13, 2023
karelz
added
the
enhancement
Product code improvement that does NOT require public API changes/additions
label
Jul 16, 2023
antonfirsov
added a commit
that referenced
this issue
Jul 18, 2023
ghost
removed
the
in-pr
There is an active PR which will close this issue when it is merged
label
Jul 18, 2023
ghost
locked as resolved and limited conversation to collaborators
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Net.Http
enhancement
Product code improvement that does NOT require public API changes/additions
Moving the remaining items out of #83734 to make tracking easier (the changes in the original issue were backported to 6.0 and 7.0).
We should consider including more information in the
System.Net.Http
events:RequestHeadersStart
.While we log a lot of request information in
RequestStart
, we may end up sending multiple requests on the wire (redirects, retries) as part of a single RequestStart/Stop pair, and there is currently no way to tell from events where those requests are being made.Also while we log the request version in
RequestStart
, there is no reliable way to get the protocol version that was actually used as a result of ALPN/version policy from events (in some cases it is implied if you see other events likeRequestLeftQueue
).The following is the same parameter signature as
RequestStart
with the exception of omitting theHttpVersionPolicy
since it doesn't have meaning at this layer (we already know exactly what version we're using).This should include the new Uri we are going to try redirecting to. I don't have a strong opinion on including the whole Uri vs separating the scheme/host/port/path...
+void Redirect(string redirectUri);
The text was updated successfully, but these errors were encountered: