Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT, SIMD Intrinsics: Recognize ~A & B as VectorXxx.AndNot(B, A) #78303

Closed
sunkin351 opened this issue Nov 14, 2022 · 3 comments
Closed

JIT, SIMD Intrinsics: Recognize ~A & B as VectorXxx.AndNot(B, A) #78303

sunkin351 opened this issue Nov 14, 2022 · 3 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@sunkin351
Copy link

I love the new SIMD intrinsic surface area you guys have released with .NET 7, and would like to propose this improvement to JIT pattern recognition.

Although micro-benchmarks don't reveal any performance improvement on my CPU to use the AndNot() intrinsic over ~A & B, it does to my knowledge result in 1 or more fewer instructions and thus benefits code size.

For reference, my CPU is a Ryzen 2700.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 14, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 14, 2022
@ghost
Copy link

ghost commented Nov 14, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

I love the new SIMD intrinsic surface area you guys have released with .NET 7, and would like to propose this improvement to JIT pattern recognition.

Although micro-benchmarks don't reveal any performance improvement on my CPU to use the AndNot() intrinsic over ~A & B, it does to my knowledge result in 1 or more fewer instructions and thus benefits code size.

For reference, my CPU is a Ryzen 2700.

Author: sunkin351
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion SingleAccretion added this to the Future milestone Nov 14, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 14, 2022
@SingleAccretion SingleAccretion added help wanted [up-for-grabs] Good issue for external contributors untriaged New issue has not been triaged by the area owner labels Nov 14, 2022
@SingleAccretion
Copy link
Contributor

A good place for this reduction would be in morph, fgOptimizeHWIntrinsic.

@SingleAccretion SingleAccretion removed the untriaged New issue has not been triaged by the area owner label Nov 14, 2022
@EgorBo EgorBo added the good first issue Issue should be easy to implement, good for first-time contributors label Nov 14, 2022
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Feb 11, 2023
@SkiFoD
dotnet#78303 Add transformation ~v1 & v2 to VectorXxx.AndNot(v1, v2)
4f32df9
@SkiFoD SkiFoD mentioned this issue Feb 11, 2023
Merged
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Feb 19, 2023
@SkiFoD
dotnet#78303 Moved code under fgOptimizeHWIntrinsic
66b4ab0
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Feb 19, 2023
@SkiFoD
dotnet#78303 Fix for merge
a1ae670
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Mar 1, 2023
@SkiFoD
dotnet#78303 Resolved some comments
2f0e1a8
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Mar 1, 2023
@SkiFoD
dotnet#78303 Resolved some comments
56e1bea
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Mar 6, 2023
@SkiFoD
dotnet#78303 Build fix. Insert 'break;' to avoid fall-through
94f1ba7
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Mar 7, 2023
@SkiFoD
dotnet#78303 Changed the checks for the cases
a5a1b44
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Mar 11, 2023
@SkiFoD
dotnet#78303 Comment fix
c24f97b
SkiFoD added a commit to SkiFoD/runtime that referenced this issue May 1, 2023
@SkiFoD
dotnet#78303 Added a description for the method.
fe39bf6
SkiFoD added a commit to SkiFoD/runtime that referenced this issue Aug 14, 2023
@SkiFoD
dotnet#78303 Fix of formatting
bec1de3
EgorBo added a commit that referenced this issue Sep 4, 2023
@SkiFoD @EgorBo
#78303 Add transformation ~v1 & v2 to VectorXxx.AndNot(v1, v2) (#81993)
13a225f 
Co-authored-by: EgorBo <[email protected]>
@EgorBo
Copy link
Member

EgorBo commented Oct 17, 2023

Closed by #81993

@EgorBo EgorBo closed this as completed Oct 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@EgorBo @sunkin351 @SingleAccretion