-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile configurations to WasmBuildTests and rename it to something more generic #75015
Comments
Tagging subscribers to this area: @directhex Issue DetailsThe startup code in our mobile test runners can differ from the startup in XA and XI resulting in issues like mono_marshal_ilgen_init symbol is private going undetected. Wasm built a CI leg that would grab the workloads, install them, and then replace the mono runtime pack with the one built in tree. It would then execute smoke tests, which would be able to root out fundamental startup problems. We should add the mobile configurations to this leg and rename it to something like "WorkloadBuildTests". For iOS/Android, we should execute tests on device.
|
fyi, I have some non-trivial changes in the pipeline to support net6-on-7 workload cases. |
The various mobile jobs should be split into build+library-tests. And the build jobs can upload the nuget packages, which can then be downloaded by a workload-install-test job, and then I will add |
This should fit in well with my work on doing the same kinda "collect nugets then install workload" stuff to support multithreaded and perftrace for wasm. |
Right now, I'm running this via: ``` ./.dotnet/dotnet msbuild src/mono/mobile/test-workloads.proj /p:Workload=WORKLOADNAME /t:restore ./.dotnet/dotnet msbuild src/mono/mobile/test-workloads.proj /p:Workload=WORKLOADNAME /t:build ./.dotnet/dotnet msbuild src/mono/mobile/test-workloads.proj /p:Workload=WORKLOADNAME /t:buildtests /p:RunSmokeTestsOnly=true /p:TestOS=OSOFTESTBUILD /p:TestArchitecture=ARCHOFTESTBUILD ``` Probably needs a value for DevTeamProvisioning passing through to it too. Just throwing this into a draft PR for some initial eyeballs. With the extra properties and slight changes, workloads-testing.targets was basically already fine. The annoyance is that you need to build so many configurations (everything within a workload, which might be 5 runtimes and 5 cross-compilers) for a simple test of a single workload (which expects all the relevant nupkgs to be available, even if you're only testing one of them)
@directhex instead of going the WBT route and depending on all the mobile jobs to finish, add a job that runs against the last good official build. That way you have all of the artifacts in place and can just test. It's still early enough to catch things should they happen. |
Do we have any existing cases like that of consuming builds across executions I can use as a model? |
I'm not sure. I'm open to any ideas you have that would make the setup less daunting of a task. |
please resolve this cc @radical |
The startup code in our mobile test runners can differ from the startup in XA and XI, resulting in issues like mono_marshal_ilgen_init symbol is private going undetected. Wasm built a CI leg that would grab the workloads, install them, and then replace the mono runtime pack with the one built in tree. It would then execute smoke tests, which would be able to root out fundamental startup problems.
We should add the mobile configurations to this leg and rename it to something like "WorkloadBuildTests". For iOS/Android, we should execute tests on device.
The text was updated successfully, but these errors were encountered: