-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented 7.0 APIs in System.Security #72401
Comments
@bartonjs I can take care of the the S.S.Cryptography (not Cose) ones; I think we're just missing some |
Let me know if any of the APIs in the list above already had |
@jozkee should already be working on the COSE ones. |
@bartonjs @carlossanlop I'm a bit perplexed about the It says this API is new in .NET 7. That can't be though, they are in .NET 6, too. Oh, but wait, it says it's inherited from Why doesn't .NET 6 consider them "overrides" like they are in .NET 7, even when they were both overridden between 6 and 7? |
@vcsjones @bartonjs Update: It's possible that many of the APIs reported here were documented in Preview6. This porting PR will take care of them: dotnet/dotnet-api-docs#8242 After merging the PR, I'll update the list of undocumented APIs in this issue. |
Here is the latest list of undoc APIs as of Preview6: Obsolete (Preview6)
|
@carlossanlop Most of what's in that table, other than COSE, is virtual members that aren't overridden (at least, not on their relevant platform)... and currently show up just fine. e.g. https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.rsacng?view=net-6.0 has (inherited) docs for TrySignHash. |
Below is the most up to date list as of Preview7. It excludes anything that got the inheritdoc tag added, which I already ported here: dotnet/dotnet-api-docs#8335 Obsolete (Preview7)
|
I generated a report yesterday, and these are the APIs that are still undocumented. My guess is that they were introduced in RC1? Undoc as of RC1
|
Yep. Please stop running doc verification against builds newer than the doc system. |
@bartonjs I'm not sure what you mean. This is the latest status of the |
Ah, I read it as backwards, that those were API members from the RC2 tree that didn't have documentation yet (because they were newer than the docs system). Instead, I see that it's that dotnet-api-docs now has the structural docs for members, but that the doc-loading PR hasn't happened yet. Those members are all (believed to be) already documented, e.g. https://github.com/dotnet/runtime/blob/main/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/CertificateRequestLoadOptions.cs. Either way, there's no actionable work from that table. |
FYI I ported what I could find, and got it merged here: dotnet/dotnet-api-docs#8414 After merging, I generated the report again, and found a few System.Security APIs that still need docs. I shared them in this new issue: #76049 |
@dotnet/area-system-security
Below is the list of APIs that were introduced in 7.0 and have not yet been fully documented.
Relevant dates:
The latest table as of Preview6 can be found in this comment.
Obsolete (as of Preview5)
Partially undocumented APIs
The text was updated successfully, but these errors were encountered: