Review workaround for HalfToInt16Bits and Int16BitsToHalf in Cbor

[jeffhandley]

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround in place and it's unclear if the backing issue that necessitated the workaround has been resolved.

• The original issue was: Consider adding HalfToInt16Bits and Int16BitsToHalf to BitConverter · Issue #38288 · dotnet/runtime
• The PR that introduced the workaround was: [CBOR] Use System.Half for encoding and decoding half-precision data items by eiriktsarpalis · Pull Request #38466 · dotnet/runtime

runtime/src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/HalfHelpers.cs

Lines 8 to 12 in f04a242

	namespace System.Formats.Cbor
	{
	// Temporarily implements missing APIs for System.Half
	// Remove class once https://github.com/dotnet/runtime/issues/38288 has been addressed
	internal static class HalfHelpers

The workaround should be evaluated to determine if it's still necessary. With the findings, we should either update the code to remove the workaround, or the code comment to reference an open issue for tracking when we can remove the workaround.

/cc @deeprobin

[ghost]

Tagging subscribers to this area: @dotnet/area-system-formats-cbor
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround in place and it's unclear if the backing issue that necessitated the workaround has been resolved.

• The original issue was: Consider adding HalfToInt16Bits and Int16BitsToHalf to BitConverter · Issue #38288 · dotnet/runtime
• The PR that introduced the workaround was: [CBOR] Use System.Half for encoding and decoding half-precision data items by eiriktsarpalis · Pull Request #38466 · dotnet/runtime

runtime/src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/HalfHelpers.cs

Lines 8 to 12 in f04a242

	namespace System.Formats.Cbor
	{
	// Temporarily implements missing APIs for System.Half
	// Remove class once https://github.com/dotnet/runtime/issues/38288 has been addressed
	internal static class HalfHelpers

The workaround should be evaluated to determine if it's still necessary. With the findings, we should either update the code to remove the workaround, or the code comment to reference an open issue for tracking when we can remove the workaround.

/cc @deeprobin

Author:	jeffhandley
Assignees:	-
Labels:	area-System.Formats.Cbor
Milestone:	-

[teo-tsirpanis]

This is an old edition of the file. The issue has been addressed with #62872; if you take a look at the current sources, you will see that we forward to the existing BCL methods. The HalfHelpers class is still needed to uniformly convert between halfs and floats across .NET Standard 2.0 and modern .NET.

[jeffhandley]

Thanks, @teo-tsirpanis! I'll update the comment to reflect that updated info.

[jeffhandley]

Oh, I see the comment doesn't even exist anymore. Excellent. Thanks again.