Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] System.Tests.DateTimeOffsetTests & DateTimeOffset test failures #60562

Open
Tracked by #64603
steveisok opened this issue Oct 18, 2021 · 5 comments
Open
Tracked by #64603

Comments

@steveisok
Copy link
Member

I believe these test failures are due to differences in Android's handling of the th-TH culture, but we should validate fully.

1.) DateTimeOffsetTests.ToString_MatchesExpected & TryFormat_MatchesExpected

Several failures surrounding:

yield return new object[] { DateTimeOffset.MaxValue, "yy", thTH, "42" };

if (PlatformDetection.IsNotInvariantGlobalization)
yield return new object[] { DateTimeOffset.MaxValue, new string('y', i), thTH, 10542.ToString("D" + i) };

Example failures:

Assert.Equal() Failure
              ↓ (pos 0)
    Expected: 42
    Actual:   99
Expected: 0010542
    Actual:   0009999

2.) DateTimeOffsetTests.ToString_Invoke_ReturnsExpected & TryFormat_MatchesExpected

Same problem as #1 with test failures surrounding:

yield return new object[] { DateTime.MaxValue, "yy", thTH, "42" };

yield return new object[] { DateTime.MaxValue, new string('y', i), thTH, 10542.ToString("D" + i) };

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 18, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@steveisok steveisok added os-android area-System.Runtime and removed untriaged New issue has not been triaged by the area owner labels Oct 18, 2021
@steveisok steveisok added this to the 7.0.0 milestone Oct 18, 2021
@jeffhandley
Copy link
Member

Tagging @dotnet/area-system-runtime since the bot didn't.

@mkhamoyan mkhamoyan self-assigned this Jul 20, 2022
mkhamoyan added a commit that referenced this issue Aug 5, 2022
@mkhamoyan mkhamoyan modified the milestones: 7.0.0, Future Aug 9, 2022
@mkhamoyan mkhamoyan removed their assignment Jun 25, 2024
@mkhamoyan
Copy link
Contributor

cc @vitek-karas

@vitek-karas
Copy link
Member

/cc @matouskozak

@Clockwork-Muse
Copy link
Contributor

... these tests are relying on (loaded) host culture data, which isn't guaranteed to be stable (we've had multiple issues from when ICU decided to add non-breaking spaces, for instance).
Should we manually construct the relevant culture details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants