Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: ConnectWithCertificateForDifferentName_Throws - NullReferenceException #56454

Closed
karelz opened this issue Jul 28, 2021 · 5 comments · Fixed by #56283
Closed

Test failure: ConnectWithCertificateForDifferentName_Throws - NullReferenceException #56454

karelz opened this issue Jul 28, 2021 · 5 comments · Fixed by #56283
Labels
area-System.Net.Quic disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Milestone
6.0.0

Comments

@karelz
Copy link
Member

karelz commented Jul 28, 2021 •
edited
Loading

Test: System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws

Failures 5/28-7/28 (incl. PRs)

Day Failures
7/26 2x PRs -- PR #56281, PR #56306
7/27 4x PR -- PR #56367, PR #56215 (Mono), PR #56387, PR #56430
7/28 PR #56463 
System.NullReferenceException : Object reference not set to an instance of an object.

   at System.Net.Quic.Implementations.MsQuic.MsQuicConnection.ConnectAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs:line 603
   at System.Net.Quic.QuicConnection.ConnectAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs:line 68
   at System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws() in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs:line 270
--- End of stack trace from previous location ---
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 28, 2021
@ghost
Copy link

ghost commented Jul 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Test: System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws

Failures 5/28-7/28 (incl. PRs)

Day Failures
7/26 2x PRs -- PR #56281, PR #56306
7/27 4x PR -- PR #56367, PR #56215 (Mono), PR #56387, PR #56430 
System.NullReferenceException : Object reference not set to an instance of an object.

   at System.Net.Quic.Implementations.MsQuic.MsQuicConnection.ConnectAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs:line 603
   at System.Net.Quic.QuicConnection.ConnectAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs:line 68
   at System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws() in /_/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs:line 270
--- End of stack trace from previous location ---
Author: karelz
Assignees: -
Labels:

area-System.Net.Quic
Milestone: -

@karelz karelz added this to the 6.0.0 milestone Jul 28, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Jul 28, 2021
@CarnaViire
Copy link
Member

I guess the root cause is the same as in #56263 and it will most possibly be fixed in #56283

@karelz
Copy link
Member Author

karelz commented Jul 28, 2021

@CarnaViire it is weird that it started failing few days later than the related issue #56263.
I will rather disable it now and we can re-enable and retest once the PR is merged. What do you think?

karelz added a commit that referenced this issue Jul 28, 2021
@karelz
Disable test ConnectWithCertificateForDifferentName_Throws
b53afe7 
Test: System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws

Disabled test tracked by #56454
@karelz karelz mentioned this issue Jul 28, 2021
Merged
@CarnaViire
Copy link
Member

I will rather disable it now and we can re-enable and retest once the PR is merged

Sure. I just commented so we wouldn't forget about it

CarnaViire pushed a commit that referenced this issue Jul 28, 2021
@karelz
Disable test ConnectWithCertificateForDifferentName_Throws (#56456)
6c64d2e 
Test: System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateForDifferentName_Throws

Disabled test tracked by #56454
@karelz karelz added the disabled-test The test is disabled in source code against the issue label Jul 28, 2021
@karelz
Copy link
Member Author

karelz commented Jul 28, 2021

Test disabled by PR #56456 on 7/28.

@karelz karelz added the test-run-core Test failures in .NET Core test runs label Jul 28, 2021
@wfurt wfurt mentioned this issue Jul 29, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Quic disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

avoid NRE in MsQuicConnection ConnectAsync wfurt/runtime
2 participants
@CarnaViire @karelz