-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono] Make sure the iOS and MacCatalyst AOT workload packs are not imported on Windows #54944
Comments
Tagging subscribers to this area: @directhex Issue DetailsAs detailed in dotnet/maui#1443 (comment), we need windows hosted AOT compiler packs for iOS & MacCatalyst.
|
@steveisok I don't know if you need to actually run the AOT compiler on Windows, we just need to make sure these aren't imported because they are not installed on Windows: runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets Lines 23 to 25 in 685eda6
(there might be more packs than this, too) The errors you get when building iOS or MacCatalyst on Windows are:
iOS has an "offline" build on Windows that just compiles your C# code against reference assemblies. You have to use a Mac build host to do a full build with AOT. |
Thanks, I thought you were saying they needed to be imported. |
I do think this is might be a blocker for Preview 6. Is there time to solve this? |
From what I know, I believe it's too late for P6 |
Windows cannot build those targets, so don't import them. Fixes dotnet#54944
If we don't, then the aot packs will be imported on Windows when running an iOS offline build Fixes dotnet#54944
* Condition Workload AOT import to be osx only If we don't, then the aot packs will be imported on Windows when running an iOS offline build Fixes #54944 * Update src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets Co-authored-by: Larry Ewing <[email protected]> * Update WorkloadManifest.targets Co-authored-by: Steve Pfister <[email protected]> Co-authored-by: Larry Ewing <[email protected]>
As detailed in dotnet/maui#1443 (comment), we need windows hosted AOT compiler packs for iOS & MacCatalyst.
The text was updated successfully, but these errors were encountered: