-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review NetCoreAppCurrent libraries configurations which are platform specific #53900
Comments
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsSystem.Data.Odbc has a big number of platform specific configurations. As those are now shipping as part of #53439, it might make sense to review and see if some of these configurations could be collapsed together. System.Text.Encodings.Web targets a Browser even though it doesn't use any platform specific APIs. Apparently this is so that the linker can trim out Vector128 on browser-wasm: #53439 (comment). We should see if there's a better way to make this work without the platform specific configuration. There are probably more of these cases and I will add a list of packages to review at a later point. cc @ericstj @eerhardt @MichalStrehovsky @marek-safar @ajcvickers
|
cc @GrabYourPitchforks for the System.Text.Encodings.Web part as well. |
Here's a list of projects that are packable and multi-target based on the TargetFramework and TargetPlatform, ordered by the number of assemblies in the correspnding package when we ship .NET 8:
|
One library in the list that surprises me is |
Contributes to dotnet#53900
System.Data.Odbc has a big number of platform specific configurations. As those are now shipping as part of #53439, it might make sense to review and see if some of these configurations could be collapsed together.
System.Text.Encodings.Web targets a Browser even though it doesn't use any platform specific APIs. Apparently this is so that the linker can trim out Vector128 on browser-wasm: #53439 (comment). We should see if there's a better way to make this work without the platform specific configuration.
EDIT:
In addition to that, we need to make sure that all dependencies from the platform TFMs are represented in the platform agnostic TFM.
cc @ericstj @eerhardt @MichalStrehovsky @marek-safar @ajcvickers
The text was updated successfully, but these errors were encountered: