Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Security.Cryptography libraries should conform to interop guidelines #51564

Closed
Tracked by #64488
mthalman opened this issue Apr 20, 2021 · 5 comments
Closed
Tracked by #64488
Assignees
Labels
area-System.Security help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@mthalman
Copy link
Member

The following list of directories do not conform to the interop guidelines:

Specifically, the file organization section states that all Interop.*.cs files should all be defined in the Common directory. Conforming to the guidelines and having a standardized way of defining native interop supports the work for being able to track and detect platform dependencies.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Security untriaged New issue has not been triaged by the area owner labels Apr 20, 2021
@ghost
Copy link

ghost commented Apr 20, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

The following list of directories do not conform to the interop guidelines:

Specifically, the file organization section states that all Interop.*.cs files should all be defined in the Common directory. Conforming to the guidelines and having a standardized way of defining native interop supports the work for being able to track and detect platform dependencies.

Author: mthalman
Assignees: -
Labels:

area-System.Security, untriaged

Milestone: -

@vcsjones
Copy link
Member

Related / similar issue: #26541

@bartonjs bartonjs added help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels Jul 2, 2021
@bartonjs bartonjs added this to the 7.0.0 milestone Jul 2, 2021
@pedrobsaila
Copy link
Contributor

pedrobsaila commented Oct 3, 2021

Hi.
I made a first PR for this issue #59913 related to System.Security.Cryptography.Pkcs library. If it's OK with you, I will try to make small PRs for System.Security.Cryptography.X509Certificates since there are 51 Interop references inside it.

@danmoseley
Copy link
Member

@pedrobsaila I've assigned this to you ,thanks!

@bartonjs
Copy link
Member

bartonjs commented Jul 6, 2022

A current scan for LibraryImport or DllImport in the cryptography projects shows nothing outside of src\Common\src\Interop (for product code, tests have a couple)

@bartonjs bartonjs closed this as completed Jul 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

5 participants