Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto interop needs to be consolidated under src\Common\src\Interop\ #26541

Closed
stephentoub opened this issue Jun 19, 2018 · 5 comments
Closed

Crypto interop needs to be consolidated under src\Common\src\Interop\ #26541

stephentoub opened this issue Jun 19, 2018 · 5 comments
Labels
area-System.Security enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@stephentoub
Copy link
Member

There is duplication we really want to avoid. For example, CertNameToStr is used by both System.Security.Cryptography.X509Certificates and by System.Security.Cryptography.Pkcs, and they both contain their own copies of DllImports and higher-level helpers on top of them.

cc: @bartonjs
@adamgauthier
Copy link
Contributor

@stephentoub Hey, I'd like to start progress on this, seems like a good start for contributing 😄 I saw there was quite a lot of work to do, I was thinking I could split it in small PRs with each 1 to a few interop methods consolidated. It would reduce the scope, lead to faster progress and make it easier to review. Would that make sense or do you want 1 PR to do all of it?

@bartonjs
Copy link
Member

@louisto Piecemeal is perfectly fine 😄.

@louisto
Copy link

louisto commented Jul 24, 2018

@louistio 👍

@bartonjs
Copy link
Member

::hangs his head in shame::

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@bartonjs bartonjs modified the milestones: 5.0.0, Future Jul 7, 2020
@bartonjs bartonjs removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2020
@vcsjones vcsjones mentioned this issue Oct 4, 2020
Open
@vcsjones vcsjones mentioned this issue Apr 20, 2021
Closed
@bartonjs
Copy link
Member

bartonjs commented Jul 6, 2022

A current scan for LibraryImport or DllImport in the cryptography projects shows nothing outside of src\Common\src\Interop (for product code, tests have a couple)

@bartonjs bartonjs closed this as completed Jul 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Security enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

No branches or pull requests
6 participants
@stephentoub @maryamariyan @msftgits @bartonjs @adamgauthier @louisto