Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Async locals in a ContinueWith block #41984

Closed
radical opened this issue Sep 8, 2020 · 2 comments · Fixed by #56911
Closed

[wasm][debugger] Async locals in a ContinueWith block #41984

radical opened this issue Sep 8, 2020 · 2 comments · Fixed by #56911
Assignees
@thaystg
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone
7.0.0

Comments

@radical
Copy link
Member

radical commented Sep 8, 2020

wip
@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 8, 2020
@radical radical self-assigned this Sep 8, 2020
@ghost
Copy link

ghost commented Sep 8, 2020

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 8, 2020
@radical radical removed the untriaged New issue has not been triaged by the area owner label Sep 8, 2020
@lewing lewing added this to the 6.0.0 milestone Sep 30, 2020
@lewing lewing assigned thaystg and unassigned radical Aug 4, 2021
@lewing lewing modified the milestones: 6.0.0, 7.0.0 Aug 4, 2021
thaystg added a commit to thaystg/runtime that referenced this issue Aug 5, 2021
@thaystg
Adding test for dotnet#41984
c74da92
@thaystg thaystg mentioned this issue Aug 5, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 5, 2021
@thaystg
Copy link
Member

thaystg commented Aug 5, 2021

I think it's working, I added a test case for it.

@thaystg thaystg closed this as completed Aug 5, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 6, 2021
lewing pushed a commit that referenced this issue Aug 6, 2021
@thaystg @radical
[wasm][debugger] Fixing async locals in nested ContinueWith blocks (#…
c1351d6 
…56911)

* Adding test for #41984

* Adding old @radical tests and fixing it.

* Fixing tests.

* Update src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

Co-authored-by: Ankit Jain <[email protected]>

* Update src/mono/wasm/debugger/tests/debugger-test/debugger-async-test.cs

Co-authored-by: Ankit Jain <[email protected]>

* Addressing @radical comments.

* Addressing @radical comments.

* Addressing @radical comments.

Co-authored-by: Ankit Jain <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thaystg thaystg

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][debugger] Fixing async locals in nested ContinueWith blocks thaystg/runtime
4 participants
@radical @lewing @thaystg @Dotnet-GitSync-Bot