Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: ilasm round-trip badcallee #38507

Closed
BruceForstall opened this issue Jun 28, 2020 · 1 comment
Closed

Test failure: ilasm round-trip badcallee #38507

BruceForstall opened this issue Jun 28, 2020 · 1 comment
Labels
area-ILTools-coreclr
Milestone
Future

Comments

@BruceForstall
Copy link
Member

With:

set COMPlus_TieredCompilation=0
set RunningIlasmRoundTrip=1

>pushd c:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Release\JIT\\opt\\Inline\\regression\\badcallee\\badcallee

c:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Release\JIT\opt\Inline\regression\badcallee\badcallee>call c:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Release\JIT\\opt\\Inline\\regression\\badcallee\\badcallee\\badcallee.cmd -coreroot c:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Debug\tests\Core_Root
BEGIN EXECUTION
c:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Debug\tests\Core_Root\ildasm.exe /raweh /out=badcallee.dasm.il badcallee.dll
c:\gh\runtime\artifacts\tests\coreclr\Windows_NT.x64.Debug\tests\Core_Root\ilasm.exe /output=badcallee.asm.dll -QUIET -NOLOGO -DEBUG=OPT -OPTIMIZE badcallee.dasm.il
badcallee.dasm.il(48) : error : Unable to find forward reference label 'IL_0067' called from PC=3
badcallee.dasm.il(48) : error : Method 'A1' compilation failed.

***** FAILURE *****
EXECUTION OF ILASM - FAILED 1
@BruceForstall BruceForstall added this to the 5.0.0 milestone Jun 28, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 28, 2020
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Jun 28, 2020
@AndyAyersMS
Copy link
Member

This test has intentionally invalid IL (see 48d47ca), so not surprising that it won't round trip, as A1() has a branch off the end of the method.

We should exempt this test from round-tripping.

BruceForstall added a commit to BruceForstall/runtime that referenced this issue Jun 30, 2020
@BruceForstall
Disable tests for ilasm round-trip testing
51f9cbf 
Tracking issues:
dotnet#11412
dotnet#38515
dotnet#38506
dotnet#38507
dotnet#38508
dotnet#38529
BruceForstall added a commit that referenced this issue Jul 2, 2020
@BruceForstall
Enable ilasm/ildasm round trip testing in new AzDO pipeline (#38490)
d4f9424 
* Enable ilasm/ildasm round trip testing in new AzDO pipeline

Pipeline is `runtime-coreclr ilasm`.

Also, add an optional `IlasmRoundTripIncompatible` msbuild
property to allow disabling tests for the IlasmRoundTrip test.

* Disable tests for ilasm round-trip testing

Tracking issues:
#11412
#38515
#38506
#38507
#38508
#38529
@BruceForstall BruceForstall modified the milestones: 5.0.0, Future Jul 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-ILTools-coreclr
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@AndyAyersMS @BruceForstall @Dotnet-GitSync-Bot