Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up task for named runtime pack functionality #35107

Closed
2 tasks done
steveisok opened this issue Apr 17, 2020 · 2 comments · Fixed by #35124
Closed
2 tasks done

Follow up task for named runtime pack functionality #35107

steveisok opened this issue Apr 17, 2020 · 2 comments · Fixed by #35124

Comments

@steveisok
Copy link
Member

steveisok commented Apr 17, 2020

In #34980, we are overriding the name of Microsoft.NETCore.App.Runtime.{RID}.{version}.nupkg with Microsoft.NETCore.App.Runtime.Mono.{RID}.{version}.nupkg. This issue is follow up work to simplify what is being renamed.

The end result should be the same. A Microsoft.NETCore.App.Runtime.Mono.{RID}.{version}.nupkg produced for desktop mono builds.

@dagood
Copy link
Member

dagood commented Apr 17, 2020

  • Alter the MobileGetBuildRidSpecificPackageProps target to override RuntimeSpecificFrameworkSuffix with .Mono

Shouldn't need a target. Copying my suggestion from #34980 (comment) to make it easy to reach:

this should be done with a small tweak over here (but without the redundant .Mono):

https://github.com/dotnet/arcade/blob/be7971c98d4ad60cdf8c3d1aa41f950f42bd466a/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/targets/framework.packaging.targets#L224

<RidSpecificPackProperties>BaseId=$(MSBuildProjectName)$(RuntimeSpecificFrameworkSuffix).$(PackageBuildRID);IdPrefix=</RidSpecificPackProperties>

And you'd use that API here in dotnet/runtime by specifying the property:

<PropertyGroup Condition="'$(RuntimeFlavor)' == 'Mono' and '$(TargetsMobile)' != 'true'">
  <RuntimeSpecificFrameworkSuffix>.Mono</RuntimeSpecificFrameworkSuffix>
</PropertyGroup>

@dagood
Copy link
Member

dagood commented Apr 17, 2020

we are overriding the name of Microsoft.NETCore.App.Runtime with Microsoft.NETCore.App.Mono.Runtime.

Not quite: Microsoft.NETCore.App.Runtime.Mono.{RID}.{version}.nupkg

This corresponds to BaseId=$(MSBuildProjectName)$(RuntimeSpecificFrameworkSuffix).$(PackageBuildRID)

@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Apr 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants