Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer] Add RuntimeSpecificFrameworkSuffix property #35124

Merged
merged 1 commit into from
Apr 27, 2020
Merged

[installer] Add RuntimeSpecificFrameworkSuffix property #35124

merged 1 commit into from
Apr 27, 2020

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Apr 17, 2020 •
edited
Loading

This is a follow up to #34980
This PR removes MobileGetBuildRidSpecificPackageProps target and create a property group RuntimeSpecificFrameworkSuffix with .Mono inside.
fixes #35107

@ghost
Copy link

ghost commented Apr 17, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@mdh1418 mdh1418 requested review from steveisok and dagood April 17, 2020 19:09
@steveisok steveisok mentioned this pull request Apr 17, 2020
Closed
2 tasks
dagood
dagood approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to wait until dotnet/arcade#5287 flows into the repo of course.

@mdh1418 mdh1418 force-pushed the mdhwang/follow_up_named_runtime_pack_functionality branch from 10f23d0 to f7708c4 Compare April 27, 2020 16:11
@mdh1418
Copy link
Member Author

mdh1418 commented Apr 27, 2020

It looks like the arcade changes made it into this repo. Looking at eng/Version.Details.xml dotnet arcade is associated with hash e13ae00db986456a5012f2d9d479d893b3f5aff6 which is after 6763f994a1e1cf01206a5482844657be170bdeec dotnet/arcade#5287.

Had to rebase because of TargetsBrowser property added, but will squash and merge when all checks are green.

@mdh1418 mdh1418 merged commit 5bde93a into dotnet:master Apr 27, 2020
@mdh1418 mdh1418 deleted the mdhwang/follow_up_named_runtime_pack_functionality branch April 27, 2020 17:42
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagood dagood dagood approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@NikolaMilosavljevic NikolaMilosavljevic Awaiting requested review from NikolaMilosavljevic

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up task for named runtime pack functionality
3 participants
@mdh1418 @dagood @Dotnet-GitSync-Bot