-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RID-layout for OS configurations in libraries #32451
Comments
Yep, @Anipik and I talked about this and agreed this would be good, to avoid the custom runtime.json. We didn't do it in initial pass because it would churn all the projects. Now is a good time to do it. |
Things that need to get done here. Taken from @jkotas comment #33315 (comment)
|
@Anipik sounds like we can make incremental progress. Do you want to work on this and if yes, can you break down the necessary changes into individual tasks with a rough estimation? Would like to better understand the size of this task. |
The Benefits vs cost scenario is not that great for this issue, so we put it on hold. But u can summarize the steps in detail |
Follow-up on #32451 Follow-up on #80074 In #43651, the "Windows" OS name was lowercased to achieve target frameworks with RIDs in them. At that time, the original plan was to lowercase all TargetOS values but that had to be cut because of resources. This PR finishes that and updates build systems, YML, markdowns and managed components. To not break existing developer workflows, the passed-in -os value is automatically lower-cased in the script entry points and validated in the msbuild entry point.
We should switch to the well defined RID system away from our current defined OS configurations. This allows us to share the OS configuration matrix with installer and have just one central point where this is defined.
See
runtime/src/installer/Directory.Build.props
Lines 227 to 308 in 9704493
cc @Anipik @ericstj
The text was updated successfully, but these errors were encountered: