Skip to content

Commit

Permalink
Update ds-ipc-pal-namedpipe to fix shutdown race (#89619)
Browse files Browse the repository at this point in the history
  • Loading branch information
hoyosjs authored Aug 11, 2023
1 parent 5cb93f9 commit ebdd264
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/native/eventpipe/ds-ipc-pal-namedpipe.c
Original file line number Diff line number Diff line change
Expand Up @@ -635,10 +635,8 @@ ds_ipc_close (
{
EP_ASSERT (ipc != NULL);

// don't attempt cleanup on shutdown and let the OS handle it
// except in the case of listen pipes - if they leak the process
// will fail to reinitialize the pipe for embedding scenarios.
if (is_shutdown && ipc->mode != DS_IPC_CONNECTION_MODE_LISTEN) {
// don't attempt cleanup on shutdown and let the OS handle it.
if (is_shutdown) {
if (callback)
callback ("Closing without cleaning underlying handles", 100);
return;
Expand Down

0 comments on commit ebdd264

Please sign in to comment.