Make Uri Thread-Safe (#33042)

* Do not lock on string in Uri * Make Uri thread-safe without locks *A lock may still be used for custom parsers * Update comments * Use existing style for enum values * Add a comment about locking for custom parsers * Add a comment about DebugSetLeftCtor usage * Add trailing dot in exception message * Fix typos * Fix typo Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: Stephen Toub <[email protected]>
dotnet · May 9, 2020 · e18250b · e18250b
1 parent 6b5850f
commit e18250b
Show file tree

Hide file tree

Showing 7 changed files with 269 additions and 126 deletions.
diff --git a/src/libraries/System.Private.Uri/src/Resources/Strings.resx b/src/libraries/System.Private.Uri/src/Resources/Strings.resx
@@ -1,4 +1,5 @@
-<root>
+<?xml version="1.0" encoding="utf-8"?>
+<root>
   <!-- 
     Microsoft ResX Schema 
     
@@ -191,4 +192,7 @@
   <data name="Arg_KeyNotFoundWithKey" xml:space="preserve">
     <value>The given key '{0}' was not present in the dictionary.</value>
   </data>
+  <data name="net_uri_InitializeCalledAlreadyOrTooLate" xml:space="preserve">
+    <value>UriParser's base InitializeAndValidate may only be called once on a single Uri instance and only from an override of InitializeAndValidate.</value>
+  </data>
 </root>