Skip to content

Commit

Permalink
Remove XUnit reference metadata from tests I switched over last week (#…
Browse files Browse the repository at this point in the history 
…61691)

During code review of my latest PR Bruce raised the concern that
hard-coding public key values and version ID for the xunit.core
reference will cause enormous maintenance pain if we decide to
upgrade to a newer version of the module in the future. As Jeremy
verified that the metadata is not really needed, I'm deleting it
from all tests I switched over last week.

Thanks

Tomas
  • Loading branch information
@trylek
trylek authored Nov 17, 2021
1 parent c03f4ec commit de883e3
Show file tree
Hide file tree
Showing 2,421 changed files with 2,421 additions and 16,947 deletions.
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_b.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_i4.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_objref.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@
.assembly 'test'
{
}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_r4.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_r8.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_struct.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge/huge_u8.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/huge_struct.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'huge_strcut.exe'
// MVID: {23E3D49B-6CFD-4DA0-8C9D-A611CE0BA103}
.namespace JitTest
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/lcs/lcs_ldlen.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'lcs.exe'
// MVID: {52ED7FCA-78F1-42F6-8DE5-7388302AFAA6}
.namespace JitTest
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/address.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@
.assembly 'test'
{
}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/arrres.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@
.assembly 'arrres'// as "arrres"
{
}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'arrres.exe'
.namespace GCTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/gcarr.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,7 @@
.assembly 'gcarr'// as "gcarr"
{
}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'gcarr.exe'
.namespace GCTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/initializearray.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,7 @@
.hash algorithm 0x00008004
.ver 0:0:0:0
}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module initializearray.exe
.imagebase 0x00400000
.file alignment 0x00000200
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/initializearray_enum.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,7 @@ class My {
.hash algorithm 0x00008004
.ver 0:0:0:0
}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module initializearray_enum.exe
// MVID: {88A311DA-3D49-42AC-8FA7-6DB1266177BC}
.imagebase 0x00400000
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/ldelem_get.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/length0.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/lengthm2.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
// MVID: {23E3D49B-6CFD-4DA0-8C9D-A611CE0BA103}
.namespace JitTest
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/misc/selfref.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'selfref.exe'
// MVID: {57800D71-6F51-4ACF-BC86-8F3D2FBAC8E1}
.namespace GCTest
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/float64_range1.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/float64_range2.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/int32_0.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/int32_0_5a.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/int32_0_5b.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/int32_1.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/int32_m1.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
8 changes: 1 addition & 7 deletions src/tests/JIT/Methodical/Arrays/range/int32_neg_range.il
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@


}
.assembly extern xunit.core
{
.publickeytoken = (
8d 05 b1 bb 7a 6f db 6c
)
.ver 2:4:2:0
}
.assembly extern xunit.core {}
.module 'test.exe'
.namespace JitTest
{
Expand Down
Loading

0 comments on commit de883e3

Please sign in to comment.