Don't have struct local in ValueStringBuilder due to hitting JIT opti…

…mization limits Cf. #67448 (comment)
dotnet · Apr 4, 2022 · da31c0b · da31c0b
1 parent 20842e6
commit da31c0b
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/libraries/Common/src/System/Text/ValueStringBuilder.cs b/src/libraries/Common/src/System/Text/ValueStringBuilder.cs
@@ -170,10 +170,9 @@ public void Insert(int index, string? s)
         public void Append(char c)
         {
             int pos = _pos;
-            Span<char> chars = _chars;
-            if ((uint)pos < (uint)chars.Length)
+            if ((uint)pos < (uint)_chars.Length)
             {
-                chars[pos] = c;
+                _chars[pos] = c;
                 _pos = pos + 1;
             }
             else
@@ -191,10 +190,9 @@ public void Append(string? s)
             }
 
             int pos = _pos;
-            Span<char> chars = _chars;
-            if (s.Length == 1 && (uint)pos < (uint)chars.Length) // very common case, e.g. appending strings from NumberFormatInfo like separators, percent symbols, etc.
+            if (s.Length == 1 && (uint)pos < (uint)_chars.Length) // very common case, e.g. appending strings from NumberFormatInfo like separators, percent symbols, etc.
             {
-                chars[pos] = s[0];
+                _chars[pos] = s[0];
                 _pos = pos + 1;
             }
             else