Skip to content

Commit

Permalink
[wasm] Add new ci jobs to run AOT tests which need lot of resources
Browse files Browse the repository at this point in the history
Some library tests fail to AOT on helix by getting oomkill'ed. Since the
build machine have more resources than helix, we can AOT these specific
library tests there, and send the built output to helix to run.
  • Loading branch information
radical committed Mar 23, 2022
1 parent 491bba8 commit c5549cb
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
3 changes: 2 additions & 1 deletion eng/pipelines/common/templates/wasm-library-aot-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ parameters:
extraBuildArgs: ''
extraHelixArgs: ''
isExtraPlatformsBuild: false
buildAOTOnHelix: true
nameSuffix: ''
platforms: []
runAOT: false
Expand All @@ -18,7 +19,7 @@ jobs:
platforms: ${{ parameters.platforms }}
nameSuffix: ${{ parameters.nameSuffix }}
isExtraPlatforms: ${{ parameters.isExtraPlatformsBuild }}
extraBuildArgs: /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=${{ parameters.runAOT }} ${{ parameters.extraBuildArgs }}
extraBuildArgs: /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=${{ parameters.buildAOTOnHelix }} /p:RunAOTCompilation=${{ parameters.runAOT }} ${{ parameters.extraBuildArgs }}
extraHelixArgs: /p:NeedsToBuildWasmAppsOnHelix=true ${{ parameters.extraHelixArgs }}
alwaysRun: ${{ parameters.alwaysRun }}
runSmokeOnlyArg: $(_runSmokeTestsOnlyArg)
24 changes: 24 additions & 0 deletions eng/pipelines/runtime-extra-platforms-wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ jobs:
runAOT: true
alwaysRun: true

# High resource AOT Library tests
- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
parameters:
platforms:
- Browser_wasm
- Browser_wasm_win
nameSuffix: _HighResource_AOT
extraBuildArgs: /p:TestAssemblies=false /p:RunHighAOTResourceRequiringTestsOnly=true
buildAOTOnHelix: false
runAOT: true
alwaysRun: true

#
# ********** For !rolling builds, IOW - PR builds *************
# - run everything, if relevant paths changed
Expand Down Expand Up @@ -72,6 +84,18 @@ jobs:
runAOT: true
alwaysRun: ${{ parameters.isWasmOnlyBuild }}

# High resource AOT Library tests
- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
parameters:
platforms:
- Browser_wasm
- Browser_wasm_win
nameSuffix: _HighResource_AOT
extraBuildArgs: /p:TestAssemblies=false /p:RunHighAOTResourceRequiringTestsOnly=true
buildAOTOnHelix: false
runAOT: true
alwaysRun: ${{ parameters.isWasmOnlyBuild }}

# Wasm.Build.Tests
- template: /eng/pipelines/common/templates/wasm-build-tests.yml
parameters:
Expand Down

0 comments on commit c5549cb

Please sign in to comment.