Skip to content

Commit

Permalink
Delete dead code related to intercept stubs (#105127)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkotas authored Jul 21, 2024
1 parent 06b011a commit 894f22d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
12 changes: 0 additions & 12 deletions src/coreclr/vm/dllimport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -688,16 +688,6 @@ class ILStubState : public StubState
pcsDispatch->EmitCALL(METHOD__STUBHELPERS__SET_LAST_ERROR, 0, 0);
}

#if defined(TARGET_X86)
if (SF_IsForwardDelegateStub(m_dwStubFlags))
{
// the delegate may have an intercept stub attached to its sync block so we should
// prevent it from being garbage collected when the call is in progress
pcsDispatch->EmitLoadThis();
pcsDispatch->EmitCALL(METHOD__GC__KEEP_ALIVE, 1, 0);
}
#endif // defined(TARGET_X86)

#ifdef VERIFY_HEAP
if (SF_IsForwardStub(m_dwStubFlags) && g_pConfig->InteropValidatePinnedObjects())
{
Expand Down Expand Up @@ -5143,8 +5133,6 @@ namespace
// copy the stack arg byte count from the stub MD to the target MD - this number is computed
// during stub generation and is copied to all target MDs that share the stub
// (we don't set it for varargs - the number is call site specific)
// also copy the "takes parameters with copy constructors" flag which is needed to generate
// appropriate intercept stub

WORD cbStackArgSize = pStubMD->AsDynamicMethodDesc()->GetNativeStackArgSize();
if (pTargetMD->IsNDirect())
Expand Down
8 changes: 0 additions & 8 deletions src/coreclr/vm/stubmgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1258,14 +1258,6 @@ BOOL StubLinkStubManager::DoTraceStub(PCODE stubStartAddress,
LOG((LF_CORDB, LL_INFO10000,
"StubLinkStubManager::DoTraceStub: stub=%p\n", stub));

//
// If this is an intercept stub, we may be able to step
// into the intercepted stub.
//
// <TODO>!!! Note that this case should not be necessary, it's just
// here until I get all of the patch offsets & frame patch
// methods in place.</TODO>
//
TADDR pRealAddr = 0;
if (stub->IsMulticastDelegate())
{
Expand Down

0 comments on commit 894f22d

Please sign in to comment.