Remove some unused unmanaged->managed direction methods

dotnet · Jul 11, 2022 · 72e9f03 · 72e9f03
1 parent 07ce896
commit 72e9f03
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 32 deletions.
diff --git a/.../System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ArrayMarshaller.cs b/.../System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ArrayMarshaller.cs
@@ -34,7 +34,7 @@ public static unsafe class ArrayMarshaller<T, TUnmanagedElement>
 
             // Always allocate at least one byte when the array is zero-length.
             int spaceToAllocate = Math.Max(checked(sizeof(TUnmanagedElement) * numElements), 1);
-            return (byte*)Marshal.AllocCoTaskMem(spaceToAllocate);
+            return (TUnmanagedElement*)Marshal.AllocCoTaskMem(spaceToAllocate);
         }
 
         public static ReadOnlySpan<T> GetManagedValuesSource(T[]? managed)
@@ -126,21 +126,6 @@ public void FromManaged(T[]? array, Span<TUnmanagedElement> buffer)
             /// </summary>
             public TUnmanagedElement* ToUnmanaged() => (TUnmanagedElement*)Unsafe.AsPointer(ref GetPinnableReference());
 
-            /// <summary>
-            /// Sets the unmanaged value representing the array.
-            /// </summary>
-            /// <param name="value">The unmanaged value.</param>
-            public void FromUnmanaged(TUnmanagedElement* value)
-            {
-                _allocatedMemory = value;
-            }
-
-            /// <summary>
-            /// Returns the managed array.
-            /// </summary>
-            /// <seealso cref="CustomTypeMarshallerDirection.Out"/>
-            public T[]? ToManaged() => _managedArray;
-
             /// <summary>
             /// Frees resources.
             /// </summary>

diff --git a/....Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/PointerArrayMarshaller.cs b/....Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/PointerArrayMarshaller.cs
@@ -126,18 +126,6 @@ public void FromManaged(T*[]? array, Span<TUnmanagedElement> buffer)
             /// </summary>
             public TUnmanagedElement* ToUnmanaged() => (TUnmanagedElement*)Unsafe.AsPointer(ref GetPinnableReference());
 
-            /// <summary>
-            /// Sets the unmanaged value representing the array.
-            /// </summary>
-            /// <param name="value">The unmanaged value.</param>
-            public void FromUnmanaged(TUnmanagedElement* value) => _allocatedMemory = value;
-
-            /// <summary>
-            /// Returns the managed array.
-            /// </summary>
-            /// <seealso cref="CustomTypeMarshallerDirection.Out"/>
-            public T*[]? ToManaged() => _managedArray;
-
             /// <summary>
             /// Frees resources.
             /// </summary>

diff --git a/src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs b/src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
@@ -2174,8 +2174,6 @@ public void FromManaged(T[]? array, System.Span<TUnmanagedElement> buffer) { }
             public ref TUnmanagedElement GetPinnableReference() { throw null; }
             public static ref T GetPinnableReference(T[]? array) { throw null; }
             public TUnmanagedElement* ToUnmanaged() { throw null; }
-            public void FromUnmanaged(TUnmanagedElement* value) { }
-            public T[]? ToManaged() { throw null; }
             public void Free() { }
         }
     }
@@ -2312,8 +2310,6 @@ public void FromManaged(T*[]? array, System.Span<TUnmanagedElement> buffer) { }
             public ref TUnmanagedElement GetPinnableReference() { throw null; }
             public static ref byte GetPinnableReference(T*[]? array) { throw null; }
             public TUnmanagedElement* ToUnmanaged() { throw null; }
-            public void FromUnmanaged(TUnmanagedElement* value) { }
-            public T*[]? ToManaged() { throw null; }
             public void Free() { }
         }
     }