Make the buffer size configurable for generational aware analysis (#4…

…0918)
dotnet · Aug 17, 2020 · 63adbf2 · 63adbf2
1 parent 7918347
commit 63adbf2
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 8 deletions.
diff --git a/src/coreclr/src/vm/eventpipe.cpp b/src/coreclr/src/vm/eventpipe.cpp
@@ -22,7 +22,6 @@
 #include "win32threadpool.h"
 #include "ceemain.h"
 #include "configuration.h"
-#include "genanalysis.h"
 
 #ifdef TARGET_UNIX
 #include "pal.h"

diff --git a/src/coreclr/src/vm/finalizerthread.cpp b/src/coreclr/src/vm/finalizerthread.cpp
@@ -7,8 +7,6 @@
 #include "finalizerthread.h"
 #include "threadsuspend.h"
 #include "jithost.h"
-#include "eventpipe.h"
-#include "eventpipesession.h"
 #include "genanalysis.h"
 
 #ifdef FEATURE_COMINTEROP

diff --git a/src/coreclr/src/vm/gcenv.ee.standalone.cpp b/src/coreclr/src/vm/gcenv.ee.standalone.cpp
@@ -15,8 +15,6 @@
 
 #include "gctoclreventsink.h"
 #include "configuration.h"
-#include "eventpipe.h"
-#include "eventpipesession.h"
 #include "genanalysis.h"
 
 // the method table for the WeakReference class

diff --git a/src/coreclr/src/vm/gcenv.ee.static.cpp b/src/coreclr/src/vm/gcenv.ee.static.cpp
@@ -15,8 +15,6 @@
 
 #include "gctoclreventsink.h"
 #include "configuration.h"
-#include "eventpipe.h"
-#include "eventpipesession.h"
 #include "genanalysis.h"
 
 // the method table for the WeakReference class

diff --git a/src/coreclr/src/vm/genanalysis.cpp b/src/coreclr/src/vm/genanalysis.cpp
@@ -11,6 +11,7 @@ GcGenAnalysisState gcGenAnalysisConfigured = GcGenAnalysisState::Uninitialized;
 int64_t gcGenAnalysisGen = -1;
 int64_t gcGenAnalysisBytes = 0;
 int64_t gcGenAnalysisIndex = 0;
+uint32_t gcGenAnalysisBufferMB = 0;
 
 /* static */ void GenAnalysis::Initialize()
 {
@@ -27,6 +28,7 @@ int64_t gcGenAnalysisIndex = 0;
                 {
                     gcGenAnalysisIndex = CLRConfig::GetConfigValue(CLRConfig::INTERNAL_GCGenAnalysisIndex);
                     gcGenAnalysisConfigured = GcGenAnalysisState::Enabled;
+                    gcGenAnalysisBufferMB = CLRConfig::GetConfigValue(CLRConfig::INTERNAL_EventPipeCircularMB);
                 }
                 else
                 {
@@ -61,7 +63,7 @@ int64_t gcGenAnalysisIndex = 0;
     pProviders[0] = EventPipeProviderConfiguration(W("Microsoft-Windows-DotNETRuntime"), keyword, 5, nullptr);
     gcGenAnalysisEventPipeSessionId = EventPipe::Enable(
         outputPath,
-        1024,
+        gcGenAnalysisBufferMB,
         pProviders,
         providerCnt,
         EventPipeSessionType::File,