Skip to content

Commit

Permalink
Disable most of S.T.Json trimming tests on AOT the right way (#101418)
Browse files Browse the repository at this point in the history
These don't seem to use the source generator, so they're not really "trimming tests" and obviously they don't work.
  • Loading branch information
MichalStrehovsky authored Apr 24, 2024
1 parent ce0ae49 commit 5b4e770
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<Project DefaultTargets="Build">
<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" />

<ItemGroup>
<!-- These tests need to be rewritten to use source generator: https://github.com/dotnet/runtime/issues/53437,
so conditioning on RunNativeAotTestApps -->
<ItemGroup Condition="'$(RunNativeAotTestApps)' != 'true'">
<TestConsoleAppSourceFiles Include="Collections\Array.cs">
<AdditionalSourceFiles>Helper.cs</AdditionalSourceFiles>
</TestConsoleAppSourceFiles>
Expand Down
1 change: 0 additions & 1 deletion src/libraries/tests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,6 @@
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Linq.Expressions\tests\TrimmingTests\System.Linq.Expressions.TrimmingTests.proj" />
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Private.Xml\tests\TrimmingTests\System.Private.Xml.TrimmingTests.proj" />
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Runtime\tests\System.Runtime.Tests\TrimmingTests\System.Runtime.TrimmingTests.proj" />
<ProjectExclusions Condition="'$(RunNativeAotTestApps)' == 'true'" Include="$(MSBuildThisFileDirectory)\System.Text.Json\tests\System.Text.Json.Tests\TrimmingTests\System.Text.Json.TrimmingTests.proj" />

<TrimmingTestProjects Include="$(MSBuildThisFileDirectory)*\tests\**\*.TrimmingTests.proj"
Exclude="@(ProjectExclusions)"
Expand Down

0 comments on commit 5b4e770

Please sign in to comment.