Add support for multiple non-string TKey on dictionaries (#38056)

* Add support for multiple non-string TKey on dictionaries

* Fix build errors

* Fix performance regression

* Add Read/WriteWithQuotes to the remaining supported types

* Add support for a few more missing types

* Add policy support for Enum keys

* Address performance regression.

* Fix test error on netstandard

* 1. Add support for escaped characters on Read and avoid escaping on Write
2. Address some feedback

* Remove TryGet*Core methods to mitigate perf regression

* Remove duplicated escaping tests

* Cache TKey and TValue converters

* Remove duplicated code used to read the dictionary key

* Bring back TryGet*Core

* Fix test errors with floating point types

* Address nits and feedback from steveharter

src/libraries/System.Text.Json/src/Resources/Strings.resx

@@ -527,4 +527,10 @@
   <data name="DefaultIgnoreConditionInvalid" xml:space="preserve">
     <value>The value cannot be 'JsonIgnoreCondition.Always'.</value>
   </data>
+  <data name="FormatBoolean" xml:space="preserve">
+    <value>The JSON value is not in a supported Boolean format.</value>
+  </data>
+  <data name="DictionaryKeyTypeNotSupported" xml:space="preserve">
+    <value>The type '{0}' is not a supported Dictionary key type.</value>
+  </data>
 </root>

src/libraries/System.Text.Json/src/System.Text.Json.csproj

@@ -66,10 +66,10 @@
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\ConcurrentQueueOfTConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\ConcurrentStackOfTConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\DictionaryDefaultConverter.cs" />
-    <Compile Include="System\Text\Json\Serialization\Converters\Collection\DictionaryOfStringTValueConverter.cs" />
+    <Compile Include="System\Text\Json\Serialization\Converters\Collection\DictionaryOfTKeyTValueConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\ICollectionOfTConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IDictionaryConverter.cs" />
-    <Compile Include="System\Text\Json\Serialization\Converters\Collection\IDictionaryOfStringTValueConverter.cs" />
+    <Compile Include="System\Text\Json\Serialization\Converters\Collection\IDictionaryOfTKeyTValueConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IEnumerableConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IEnumerableConverterFactory.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IEnumerableConverterFactoryHelpers.cs" />
@@ -78,9 +78,9 @@
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IEnumerableWithAddMethodConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IListConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\IListOfTConverter.cs" />
-    <Compile Include="System\Text\Json\Serialization\Converters\Collection\ImmutableDictionaryOfStringTValueConverter.cs" />
+    <Compile Include="System\Text\Json\Serialization\Converters\Collection\ImmutableDictionaryOfTKeyTValueConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\ImmutableEnumerableOfTConverter.cs" />
-    <Compile Include="System\Text\Json\Serialization\Converters\Collection\IReadOnlyDictionaryOfStringTValueConverter.cs" />
+    <Compile Include="System\Text\Json\Serialization\Converters\Collection\IReadOnlyDictionaryOfTKeyTValueConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\ISetOfTConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\JsonCollectionConverter.cs" />
     <Compile Include="System\Text\Json\Serialization\Converters\Collection\JsonDictionaryConverter.cs" />

src/libraries/System.Text.Json/src/System/Text/Json/JsonConstants.cs

@@ -66,6 +66,7 @@ internal static class JsonConstants
         public const int MaxBase64ValueTokenSize = (MaxEscapedTokenSize >> 2) * 3 / MaxExpansionFactorWhileEscaping;  // 125_000_000 bytes
         public const int MaxCharacterTokenSize = MaxEscapedTokenSize / MaxExpansionFactorWhileEscaping; // 166_666_666 characters
 
+        public const int MaximumFormatBooleanLength = 5;
         public const int MaximumFormatInt64Length = 20;   // 19 + sign (i.e. -9223372036854775808)
         public const int MaximumFormatUInt64Length = 20;  // i.e. 18446744073709551615
         public const int MaximumFormatDoubleLength = 128;  // default (i.e. 'G'), using 128 (rather than say 32) to be future-proof.