Skip to content

Commit

Permalink
[release/5.0] Fix missing signatures for Cross bitness DAC symbols (#…
Browse files Browse the repository at this point in the history
…43499)

* Unify paths used for cross-bit components
* Pass down buildArchitecture for signing
* Pass target properties to signing
  • Loading branch information
hoyosjs authored Oct 17, 2020
2 parents 25e8b0d + aedbe68 commit 25c7409
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
8 changes: 4 additions & 4 deletions eng/Signing.props
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
<FileExtensionSignInfo Include=".deb;.rpm" CertificateName="LinuxSign" />
</ItemGroup>

<ItemGroup Condition="'$(CrossTargetComponentFolder)' != ''">
<CoreCLRCrossTargetItemsToSign Include="$(CoreCLRArtifactsPath)$(CrossTargetComponentFolder)/sharedFramework/*.dll" />
<CoreCLRCrossTargetItemsToSign Include="$(CoreCLRArtifactsPath)$(CrossTargetComponentFolder)/sharedFramework/*.exe" />
<ItemGroup Condition="'$(CoreCLRCrossTargetComponentDirName)' != ''">
<CoreCLRCrossTargetItemsToSign Include="$(CoreCLRArtifactsPath)$(CoreCLRCrossTargetComponentDirName)/sharedFramework/*.dll" />
<CoreCLRCrossTargetItemsToSign Include="$(CoreCLRArtifactsPath)$(CoreCLRCrossTargetComponentDirName)/sharedFramework/*.exe" />
</ItemGroup>

<!-- When doing post build signing, the file containers (e.g. nupkg, msi, etc.) are
<!-- When doing post build signing, the file containers (e.g. nupkg, msi, etc.) are
processed for signing (opened up, individually signed, etc.) and these individual ItemsToSign
elements are unnecessary. When signing within the build, we need to individually process
dll's, exes, etc. that go into msi's because these containers are not able to be processed
Expand Down
5 changes: 0 additions & 5 deletions src/coreclr/dir.common.props
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@

<!-- We are only tracking Linux Distributions for Nuget RID mapping -->
<DistroRid Condition="'$(TargetsLinux)' == 'true'">$(__DistroRid)</DistroRid>

<!-- Folder for cross target components -->
<CrossTargetComponentFolder Condition="'$(TargetArchitecture)' == 'arm64'">x64</CrossTargetComponentFolder>
<CrossTargetComponentFolder Condition="'$(TargetArchitecture)' == 'arm' and '$(TargetsWindows)' == 'true'">x86</CrossTargetComponentFolder>
<CrossTargetComponentFolder Condition="'$(TargetArchitecture)' == 'arm' and '$(TargetsLinux)' == 'true'">x64</CrossTargetComponentFolder>
</PropertyGroup>

<!-- Set the kind of PDB to Portable -->
Expand Down
3 changes: 3 additions & 0 deletions src/installer/signing/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
ArtifactsBinDir=$(ArtifactsBinDir);
ArtifactsPackagesDir=$(ArtifactsPackagesDir);
TargetOS=$(TargetOS);
TargetsLinux=$(TargetsLinux);
TargetsWindows=$(TargetsWindows);
TargetArchitecture=$(TargetArchitecture);
BuildArchitecture=$(BuildArchitecture);
NetCoreAppCurrent=$(NetCoreAppCurrent)" />

<PropertyGroup>
Expand Down

0 comments on commit 25c7409

Please sign in to comment.