-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podman tar for relative symlinks test #280
Add podman tar for relative symlinks test #280
Conversation
Where is that file coming from? |
@akoeplinger, linked issue has details. |
Ok but I don't think it should be going into the go test assets directory since it's not from their test suite and that might be confusing. |
We added docker one in the same spirit last week #279. Since they both use golang, I added it in go directory. I'm open to ideas if you prefer another directory for these. 🙂 |
I'd just create a separate folder next to golang_tar. The files in that folder are coming from https://github.com/golang/go/tree/master/src/archive/tar/testdata so I think it'd be good to have separation (also license wise) Btw. looks like there was a new test file added in golang/go@0bf7ee9 that we might want to port too. |
It's 1MB, I'll compress it with gz (they had it as bz2, which we don't support OOTB). |
I don't think 1MB is an issue fwiw |
We don't add huge files in this repo. Majority of files in golang dir are < 20 K. |
The The Personally, I prefer tests generating the archive if possible, as that makes more visible what is special about the archive under test. |
@akoeplinger, looks like auto-merge got cancelled. can you manually merge? |
I didn't yet because @tmds raised a question about generating the file instead, do we want to do that? or are we fine with the checked in file? |
I think we can do both. This one is for consistency that the podman and docker archives are exercised (these are small files). It will help projects like https://github.com/WeihanLi/nocker to use System.Formats.Tar with confidence. |
Ok sounds good. |
Test asset for dotnet/runtime#77303.