Send over the new sourcetext's content checksum when sending notification of textchanges #75928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of textchanges Calculation of this on the server was taking quite a bit of CPU (about 11.6% in the scrolling speedometer during the typing scenario). Instead, pass this data over as part of the text change notification, similar to what SerializableSourceText's serialization does.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Test insertion build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10562135 Results didn't show any samples in GetContentHash OOP (and it doesn't appear to have increased time spent in that method in VS either) baseline: target: |
CyrusNajmabadi
approved these changes
Nov 15, 2024
…ecksumInSynchronizationNotification
…sh when should be using Checksum.Create
|
New test insertion PR after commit 3: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10568078&view=results New numbers still look good, roughly same amount of work done in VS and no work done OOP |
3 tasks
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of this on the server was taking quite a bit of CPU (about 11.6% in the scrolling speedometer during the typing scenario). Instead, pass this data over as part of the text change notification, similar to what SerializableSourceText's serialization code does.