Merge release/dev17.13 to main

[dotnet-bot]

This is an automatically generated pull request from release/dev17.13 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

• https://github.com/dotnet/roslyn/find/release/dev17.13
• https://github.com/dotnet/roslyn/find/main

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.13-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.13
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.13-to-main --force

[JoeRobich]

Integration test failures may be related to this known issue. https://github.com/dotnet/core/blob/main/release-notes/9.0/known-issues.md#net-sdk-90100-rc1-will-fail-when-used-with-visual-studio-1711

[jjonescz]

Integration test failures may be related to this known issue. https://github.com/dotnet/core/blob/main/release-notes/9.0/known-issues.md#net-sdk-90100-rc1-will-fail-when-used-with-visual-studio-1711

Indeed there is a failure

Microsoft.PackageDependencyResolution.targets(266, 5): error NETSDK1060: Error reading assets file: Error loading lock file 'T:\roslyn-test\anbaudin.h1t\TestProj\obj\project.assets.json' : Could not load file or assembly 'System.Text.Json, Version=8.0.0.4, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.

but why it appears only in the one test Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRedirectFeaturesAnalyzers.DoesNotUseHostOptions_WhenEnforceCodeStyleInBuildIsTrue? Is it special somehow?

[JoeRobich]

Is it special somehow?

Looking at the other integration tests. They generate their projects from the VS templates. The CSharpRedirectFeaturesAnalyzers uses a hardcoded project file so that I can set <EnforceCodeStyleInBuild>. I am going to look at switching over to using a project template then updating the project appropriately.