Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates content exclusion for on-the-fly-docs #75172

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

akhera99
Copy link
Member

@akhera99 akhera99 commented Sep 19, 2024

Looks to see if any of the file paths of the syntax nodes that declared the symbol are excluded.
If a user is looking at docs for an excluded symbol, it now returns a new message indicating that content is excluded.

image

@akhera99 akhera99 requested a review from genlu September 19, 2024 17:42
@akhera99 akhera99 requested a review from a team as a code owner September 19, 2024 17:42
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 19, 2024
@genlu
Copy link
Member

genlu commented Sep 20, 2024

    }, LogLevel.Information));

this reminds me, we haven't added some of those telemetry to the dashboard


Refers to: src/EditorFeatures/Core.Wpf/QuickInfo/OnTheFlyDocsView.xaml.cs:220 in f65aa66. [](commit_id = f65aa66, deletion_comment = False)

@genlu
Copy link
Member

genlu commented Sep 20, 2024

        m["SymbolHeaderText"] = _onTheFlyDocsElement.SymbolSignature;

same here, do we need this in the log? #Resolved


Refers to: src/EditorFeatures/Core.Wpf/QuickInfo/OnTheFlyDocsView.xaml.cs:218 in f65aa66. [](commit_id = f65aa66, deletion_comment = False)

@genlu
Copy link
Member

genlu commented Sep 25, 2024

                ClassifiedTextElement.CreateHyperlink(EditorFeaturesResources.Describe_with_Copilot, EditorFeaturesResources.Generate_summary_with_Copilot, () =>

sorry I missed this earlier, but if I understand this correctly, we are still displaying "describe with copilot" link even for symbols we already know are being excluded, and only show the "is excluded" text after user click the link. Is that correct? If so, I think that's not a good experience, I'd suggest we show a message immediately, like "describe with copilot is unavailable since the referenced document is excluded by your org" #Resolved


Refers to: src/EditorFeatures/Core.Wpf/QuickInfo/OnTheFlyDocsView.xaml.cs:79 in f900324. [](commit_id = f900324, deletion_comment = False)

@genlu
Copy link
Member

genlu commented Sep 25, 2024

@akhera99 Could you pls add a screenshot for this change? Thanks

Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@akhera99 akhera99 enabled auto-merge (squash) September 26, 2024 16:36
@akhera99 akhera99 merged commit 2f6b493 into dotnet:main Sep 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 26, 2024
@akhera99 akhera99 removed this from the Next milestone Sep 26, 2024
@akhera99 akhera99 added this to the 17.12 P3 milestone Sep 26, 2024
333fred added a commit that referenced this pull request Sep 27, 2024
333fred added a commit that referenced this pull request Sep 27, 2024
akhera99 added a commit that referenced this pull request Sep 27, 2024
akhera99 added a commit that referenced this pull request Sep 27, 2024
akhera99 pushed a commit to akhera99/roslyn that referenced this pull request Sep 27, 2024
333fred added a commit that referenced this pull request Sep 27, 2024
333fred added a commit to 333fred/roslyn that referenced this pull request Oct 1, 2024
…terns

* upstream/main: (267 commits)
  Support long chains of `else if` statements (dotnet#74317)
  Update dependencies from https://github.com/dotnet/source-build-externals build 20240930.2
  Fix the path to the proposal (dotnet#75302)
  Fix TSA tooling (dotnet#75307)
  Clarify the bug template to request a code snippet (dotnet#75306)
  Bump razor for serialization changes (dotnet#75282)
  Disallow declaration of indexers in absence of proper DefaultMemberAttribute. (dotnet#75099)
  stoub
  use ref
  Simpler
  Simplify
  Switch to a threadlocal storage to prevent locks
  add comment
  don't mess with user caret in smart rename
  Update LanguageServer references
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2548898
  Use common helper method
  Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2548278
  Field-backed properties: additional tests (dotnet#75283)
  Revert "Updates content exclusion for on-the-fly-docs (dotnet#75172)" (dotnet#75279) (dotnet#75284)
  ...
akhera99 added a commit that referenced this pull request Oct 1, 2024
akhera99 added a commit that referenced this pull request Oct 1, 2024
akhera99 added a commit that referenced this pull request Oct 2, 2024
* Revert "Revert "Updates content exclusion for on-the-fly-docs (#75172)" (#752…" (#75324)

This reverts commit ba2f19a.

* fix error when merging

---------

Co-authored-by: Ankita Khera <[email protected]>
Co-authored-by: Ankita Khera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants