-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates content exclusion for on-the-fly-docs #75172
Conversation
src/Features/CSharp/Portable/QuickInfo/CSharpSemanticQuickInfoProvider.cs
Show resolved
Hide resolved
sorry I missed this earlier, but if I understand this correctly, we are still displaying "describe with copilot" link even for symbols we already know are being excluded, and only show the "is excluded" text after user click the link. Is that correct? If so, I think that's not a good experience, I'd suggest we show a message immediately, like "describe with copilot is unavailable since the referenced document is excluded by your org" #Resolved Refers to: src/EditorFeatures/Core.Wpf/QuickInfo/OnTheFlyDocsView.xaml.cs:79 in f900324. [](commit_id = f900324, deletion_comment = False) |
@akhera99 Could you pls add a screenshot for this change? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…dotnet#75279) This reverts commit 2f6b493.
…) (#75284) This reverts commit 2f6b493. Co-authored-by: Fred Silberberg <[email protected]>
…terns * upstream/main: (267 commits) Support long chains of `else if` statements (dotnet#74317) Update dependencies from https://github.com/dotnet/source-build-externals build 20240930.2 Fix the path to the proposal (dotnet#75302) Fix TSA tooling (dotnet#75307) Clarify the bug template to request a code snippet (dotnet#75306) Bump razor for serialization changes (dotnet#75282) Disallow declaration of indexers in absence of proper DefaultMemberAttribute. (dotnet#75099) stoub use ref Simpler Simplify Switch to a threadlocal storage to prevent locks add comment don't mess with user caret in smart rename Update LanguageServer references Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2548898 Use common helper method Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 2548278 Field-backed properties: additional tests (dotnet#75283) Revert "Updates content exclusion for on-the-fly-docs (dotnet#75172)" (dotnet#75279) (dotnet#75284) ...
* Revert "Revert "Updates content exclusion for on-the-fly-docs (#75172)" (#752…" (#75324) This reverts commit ba2f19a. * fix error when merging --------- Co-authored-by: Ankita Khera <[email protected]> Co-authored-by: Ankita Khera <[email protected]>
Looks to see if any of the file paths of the syntax nodes that declared the symbol are excluded.
If a user is looking at docs for an excluded symbol, it now returns a new message indicating that content is excluded.