Avoid span conversion in delegate extension receiver #74044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
It looks like there is still an open question in the speclet about whether to take the breaking change or not. Was that discussed in LDM? |
Not yet, I'm optimistically assuming we won't take a breaking change here. But if we will, we can always revert this. Or we can postpone this PR until after LDM if you prefer. |
Is this change blocking other work? If not, I think my preference is to postpone this PR until after an LDM decision. |
333fred
approved these changes
Jul 17, 2024
| return IsValidExtensionMethodThisArgConversion(conversion) ? conversion : Conversion.NoConversion; | ||
| } | ||
|
|
||
| // Spec 7.6.5.2: "An extension method ... is eligible if ... [an] implicit identity, reference, | ||
| // or boxing conversion exists from expr to the type of the first parameter" | ||
| public Conversion ClassifyImplicitExtensionMethodThisArgConversion(BoundExpression sourceExpressionOpt, TypeSymbol sourceType, TypeSymbol destination, ref CompoundUseSiteInfo<AssemblySymbol> useSiteInfo) | ||
| public Conversion ClassifyImplicitExtensionMethodThisArgConversion(BoundExpression sourceExpressionOpt, TypeSymbol sourceType, TypeSymbol destination, ref CompoundUseSiteInfo<AssemblySymbol> useSiteInfo, bool isMethodGroupConversion) |
There was a problem hiding this comment.
Should we update the comment above this method?
|
@cston for the second review, thanks |
cston
approved these changes
Jul 29, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speclet updates: dotnet/csharplang#8221, dotnet/csharplang#8287
Test plan: #73445