Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not offer to add default switch case when it handles null and an underlying value #74018

Merged
merged 9 commits into from
Jun 16, 2024
Merged

Do not offer to add default switch case when it handles null and an underlying value #74018

merged 9 commits into from
Jun 16, 2024

Conversation

DoctorKrolic
Copy link
Contributor

Fixes: #50983

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 15, 2024
@DoctorKrolic DoctorKrolic marked this pull request as ready for review June 15, 2024 17:30
@DoctorKrolic DoctorKrolic requested a review from a team as a code owner June 15, 2024 17:30
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 15, 2024
CyrusNajmabadi
CyrusNajmabadi approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Lgtm!

src/Analyzers/Core/Analyzers/PopulateSwitch/PopulateSwitchExpressionHelpers.cs Show resolved Hide resolved
src/Analyzers/Core/Analyzers/PopulateSwitch/PopulateSwitchExpressionHelpers.cs Outdated Show resolved Hide resolved
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 15, 2024 22:21
@CyrusNajmabadi CyrusNajmabadi merged commit 0d03b2e into dotnet:main Jun 16, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 16, 2024
@CyrusNajmabadi
Copy link
Member

Thanks!

@DoctorKrolic DoctorKrolic deleted the switch-null-and-underlying-value branch June 16, 2024 06:06
This was referenced Jun 18, 2024
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
3 participants
@DoctorKrolic @CyrusNajmabadi @jjonescz