Remove A/B option for enabling features in SG docs. #73968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@jasonmalinowski ptal (or let me know who you'd prefer review if you're on other stuff right now). |
Open
3 tasks
ToddGrun
reviewed
Jun 12, 2024
| @@ -384,7 +384,7 @@ private async Task<TestLspServer> CreateTestLspServerAsync(EditorTestWorkspace w | |||
| InitializationOptions? options, string? workspaceKind, bool mutatingLspWorkspace, TestComposition? composition = null) | |||
| { | |||
| var workspace = new EditorTestWorkspace( | |||
| composition ?? Composition, workspaceKind, configurationOptions: new WorkspaceConfigurationOptions(EnableOpeningSourceGeneratedFiles: true), supportsLspMutation: mutatingLspWorkspace); | |||
| composition ?? Composition, workspaceKind, configurationOptions: new WorkspaceConfigurationOptions(ValidateCompilationTrackerStates: true), supportsLspMutation: mutatingLspWorkspace); | |||
There was a problem hiding this comment.
why was ValidateCompilationTrackerStates: true added?
There was a problem hiding this comment.
it should have been there from teh beginning. it's helpful for tracking down bugs that jason cares about.
ToddGrun
approved these changes
Jun 12, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #73965.
SG doc features has been experimental long enough. We've shaken out the issues and can have this just be the norm. This is especially ok now that we have balanced-mode so users can have all these features, without the ide constantly rerunning generators.