Use a serialization compatible marker #73851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dibarbet
approved these changes
Jun 4, 2024
jasonmalinowski
approved these changes
Jun 4, 2024
|
(disabling automerge, think it needs 2 compiler reviews) |
|
Whoops, thank you, didn't notice this was in the compiler |
sharwell
reviewed
Jun 5, 2024
sharwell
approved these changes
Jun 5, 2024
dibarbet
approved these changes
Jun 12, 2024
|
Ping @dotnet/roslyn-compiler for reviews please. Very small change to shared code |
3 tasks
cston
approved these changes
Jun 12, 2024
CyrusNajmabadi
approved these changes
Jun 12, 2024
jjonescz
approved these changes
Jun 12, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FatalError tries to tag exceptions so that they don't get reported twice, but it uses a plain object which fails serialization/deserialization if that exception ever crosses a json rpc boundary that uses System.Text.Json. This PR changes it to something serializable.